Plasma-addons repository side changes for Differential D4803
Details
Details
- Reviewers
apol mart - Group Reviewers
Plasma - Commits
- R114:8bab9c84ab9a: Basic keyboard support in QuickShare Plasmoid Fix Quickshare Paste action not…
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| applets/quickshare/plasmoid/contents/ui/ShareDialog.qml | ||
|---|---|---|
| 54 ↗ | (On Diff #11840) | You should also do Keys.onEnterPressed (the Enter key on numpad) |
Comment Actions
I think this patch needs more testing and getting it in was premature.
One needs to be able to paste images and text as well.
| applets/quickshare/plasmoid/contents/ui/main.qml | ||
|---|---|---|
| 226 | This is not correct. What if the content isn't urls? | |
Comment Actions
Hmm, I have tested drag/dropping text, images, files, as well as copying text, images and files and then using the Paste action. They all seem to work as expected.
| applets/quickshare/plasmoid/contents/ui/main.qml | ||
|---|---|---|
| 226 | I think you are talking about the toString in line 72? If so: The objectToArray function is only called on clipboard.contentFormat() and on drop/drag.urls, so it's always only dealing with url types I think. I added the toString() because somehow it doesn't otherwise work with the QUrls returned by clipboard.contentFormat(), but it doesn't affect the urllists from drop/drag.urls, so I thought it's better to just add in the toString() instead of making a version of objectToArray just for clipboard.contentFormat(). | |