Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

Authored by yuenlim on Feb 26 2017, 7:40 AM.



Plasma-addons repository side changes for Differential D4803

Diff Detail

R114 Plasma Addons
Lint Skipped
Unit Tests Skipped
yuenlim created this revision.Feb 26 2017, 7:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2017, 7:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 28 2017, 1:20 PM
This revision is now accepted and ready to land.Feb 28 2017, 1:20 PM
broulik added inline comments.

You should also do Keys.onEnterPressed (the Enter key on numpad)

This revision was automatically updated to reflect the committed changes.
yuenlim marked an inline comment as done.Feb 28 2017, 5:39 PM
apol edited edge metadata.Mar 1 2017, 2:55 PM

I think this patch needs more testing and getting it in was premature.
One needs to be able to paste images and text as well.


This is not correct. What if the content isn't urls?

Hmm, I have tested drag/dropping text, images, files, as well as copying text, images and files and then using the Paste action. They all seem to work as expected.


I think you are talking about the toString in line 72? If so:

The objectToArray function is only called on clipboard.contentFormat() and on drop/drag.urls, so it's always only dealing with url types I think. I added the toString() because somehow it doesn't otherwise work with the QUrls returned by clipboard.contentFormat(), but it doesn't affect the urllists from drop/drag.urls, so I thought it's better to just add in the toString() instead of making a version of objectToArray just for clipboard.contentFormat().