Differential D4802

[KTextEditor] Remember file type set by user over sessions
ClosedPublic
Actions

Authored by jsalatas on Feb 26 2017, 3:55 AM.

Details

Reviewers
cullmann
Group Reviewers
Frameworks
KTextEditor
Commits
R39:ba03878378a4: Remember file type set by user over sessions
Summary

File type set by user is being reset after opening a session and reloading (F5) a file with file type set by user.

The proposed solution is to save/restore the m_fileTypeSetByUser variable in the session.

Test Plan

see the video for a before/after demonstration.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsalatas created this revision.Feb 26 2017, 3:55 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 26 2017, 3:55 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
dhaumann added subscribers: cullmann, dhaumann.Feb 26 2017, 4:49 PM

Does this fix https://bugs.kde.org/show_bug.cgi?id=358281 ?

In general, I think this looks good and your video also demonstrates this nicely.
Still, a second ok would be nice.
@cullmann Does this also look good to you?

cullmann accepted this revision.Feb 26 2017, 6:40 PM

Yeah, good catch!

This revision is now accepted and ready to land.Feb 26 2017, 6:40 PM
Closed by commit R39:ba03878378a4: Remember file type set by user over sessions (authored by jsalatas). · Explain WhyFeb 26 2017, 8:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/document/katedocument.cpp (5 lines)

Diff 11862

View Options

src/document/katedocument.cpp

Loading...