jsalatas (John Salatas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 8 2016, 4:11 AM (126 w, 4 d)
Availability
Available

Recent Activity

Fri, Nov 30

jsalatas requested review of D17249: Preserve screen colour doesn't work as expected.
Fri, Nov 30, 4:25 AM · Plasma

Jul 11 2017

jsalatas added a comment to D6473: Crash when replacing new lines with spaces.

So the question is: Why is the cursor not updated? If we can answer this, we may be able to either find that this patch is correct, or that the root of the real issue lies somewhere else...

Jul 11 2017, 9:52 PM · Kate, Frameworks
jsalatas added a comment to D6473: Crash when replacing new lines with spaces.
In D6473#124287, @kfunk wrote:

Could you add a test in e.g. autotests/src/searchbar_test.cpp?

Jul 11 2017, 9:31 PM · Kate, Frameworks
jsalatas added a comment to D6473: Crash when replacing new lines with spaces.

ping?

Jul 11 2017, 8:37 PM · Kate, Frameworks

Jul 2 2017

jsalatas updated the summary of D6473: Crash when replacing new lines with spaces.
Jul 2 2017, 10:45 PM · Kate, Frameworks
jsalatas added a comment to D6473: Crash when replacing new lines with spaces.

If the review is accepted and you want to close the bug, replace

Fixes bug 381080
https://bugs.kde.org/show_bug.cgi?id=381080

with simply

BUG: 381080

Jul 2 2017, 10:19 PM · Kate, Frameworks
jsalatas created D6473: Crash when replacing new lines with spaces.
Jul 2 2017, 9:45 PM · Kate, Frameworks

Mar 22 2017

jsalatas abandoned D5110: [KompareDiff2 Library]: Fix issues with blending diffs with files or folders.

Will recheck and create a new one....

Mar 22 2017, 8:45 PM
jsalatas added a comment to D5110: [KompareDiff2 Library]: Fix issues with blending diffs with files or folders.

Unfortunately, I don't think your approach at taking the common part of source and destination as the directory and file name is going to work in all cases:

Mar 22 2017, 5:56 PM
jsalatas added a comment to D5110: [KompareDiff2 Library]: Fix issues with blending diffs with files or folders.

And also, you are again trying to fix 2 bugs in one review request. Please submit one review per issue you fix.

Mar 22 2017, 5:44 PM

Mar 19 2017

jsalatas created D5110: [KompareDiff2 Library]: Fix issues with blending diffs with files or folders.
Mar 19 2017, 10:25 PM
jsalatas committed R39:c9cb3e9761f3: Expose additional internal View's functionality to the public API (authored by jsalatas).
Expose additional internal View's functionality to the public API
Mar 19 2017, 11:48 AM
jsalatas closed D4947: [KTextEditor] Expose additional internal View's functionality to the public API by committing R39:c9cb3e9761f3: Expose additional internal View's functionality to the public API.
Mar 19 2017, 11:48 AM · Frameworks

Mar 18 2017

jsalatas added inline comments to D5096: [Kompare] Fix the file choosing dialog not handling folders to compare anymore.
Mar 18 2017, 8:04 PM
jsalatas committed R454:847d3030f0f7: Fix the file choosing dialog not handling folders to compare anymoreHEADmaster (authored by jsalatas).
Fix the file choosing dialog not handling folders to compare anymoreHEADmaster
Mar 18 2017, 8:00 PM
jsalatas added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Sorry for late response, thanks for ping!

Mar 18 2017, 7:44 PM · Frameworks
jsalatas updated the diff for D4947: [KTextEditor] Expose additional internal View's functionality to the public API.
Mar 18 2017, 7:42 PM · Frameworks
jsalatas added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

ping?

Mar 18 2017, 12:41 PM · Frameworks
jsalatas committed R454:83c6ba01eb92: Fix the file choosing dialog not handling folders to compare anymore (authored by jsalatas).
Fix the file choosing dialog not handling folders to compare anymore
Mar 18 2017, 12:31 PM
jsalatas closed D5096: [Kompare] Fix the file choosing dialog not handling folders to compare anymore by committing R454:83c6ba01eb92: Fix the file choosing dialog not handling folders to compare anymore.
Mar 18 2017, 12:31 PM
jsalatas committed R454:4b292e07f08d: Fix Kompare not remembering settings and latest compared files (authored by jsalatas).
Fix Kompare not remembering settings and latest compared files
Mar 18 2017, 12:31 PM
jsalatas closed D5095: [Kompare] Fix Kompare not remembering settings and latest compared files by committing R454:4b292e07f08d: Fix Kompare not remembering settings and latest compared files.
Mar 18 2017, 12:31 PM
jsalatas updated the test plan for D5096: [Kompare] Fix the file choosing dialog not handling folders to compare anymore.
Mar 18 2017, 11:26 AM
jsalatas created D5096: [Kompare] Fix the file choosing dialog not handling folders to compare anymore.
Mar 18 2017, 11:09 AM
jsalatas created D5095: [Kompare] Fix Kompare not remembering settings and latest compared files.
Mar 18 2017, 11:08 AM
jsalatas abandoned D5075: [Kompare] Rework on Files Page and save recently opened URLs.
Mar 18 2017, 9:46 AM
jsalatas added a comment to D5075: [Kompare] Rework on Files Page and save recently opened URLs.

Well, my first nitpick is that you are fixing 2 separate bugs and so should be submitting 2 separate code reviews.

Mar 18 2017, 9:45 AM

Mar 17 2017

jsalatas created D5075: [Kompare] Rework on Files Page and save recently opened URLs.
Mar 17 2017, 8:05 AM

Mar 12 2017

jsalatas added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Reading this API, I still have some general thoughts:
This is the first time we expose the concept of "visible lines". So far, this only exists internally in katetextfolding.h/cpp. By itself, this is fine, but given we do not expose folding information so far, I think the API is not complete.
If we already provide infos about visible first / last visible line in a view, the complete API should also contain functions like isLineVisible(int line). But here, we have a problem, since the fistVisibleLine() and lastVisibleLine() are not the text folding lines, instead, its the visually visible drawn line on screen. Here, the term "visible" is used in two different contexts: once for screen visibility, and once for folding information. Internally, KTextEditor uses terms viewLine or displayedLine for this. Maybe displayedLine is the best here?

Any comments? Are we lacking more API to make it feel complete?

Mar 12 2017, 9:30 PM · Frameworks
jsalatas updated the diff for D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

According to @cullmann's and @dhaumann's feedback created the enum LineType and also renamed firstVisibleLine() and lastVisibleLine() to firstDisplayedLine() and lastDisplayedLine()

Mar 12 2017, 9:25 PM · Frameworks
jsalatas updated the diff for D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

in firstVisibleLine() and lastVisibleLine() provide the option for real lines (in cases of folded text).

Mar 12 2017, 3:06 PM · Frameworks

Mar 11 2017

jsalatas updated the diff for D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Implemented additional functions as non-virtuals, according to @cullmann's suggestion.

Mar 11 2017, 9:41 PM · Frameworks
jsalatas added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

ping?

Mar 11 2017, 9:26 AM · Frameworks

Mar 7 2017

jsalatas updated the diff for D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Diff updated. Hope I addressed all issues :\

Mar 7 2017, 5:08 AM · Frameworks

Mar 6 2017

jsalatas added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Thank you all for your feedback. I'll update soon....

Mar 6 2017, 5:55 PM · Frameworks
jsalatas added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.

Milian had in mind that you can take charge of Kompare and implement your ideas rather than release new app. :)

Mar 6 2017, 6:11 AM · Frameworks

Mar 5 2017

jsalatas added a comment to D4947: [KTextEditor] Expose additional internal View's functionality to the public API.
In D4947#92889, @mwolff wrote:

You will have to create a separate interface for this, similar to what we have done in the past, with a TODO note that this should be merged in time for KF6.

You mean an interface similar to TextHintInterface, CodeCompletionInterface, ConfigInterface, AnnotationViewInterface, etc or something else? If something else, could you please provide an example?

Mar 5 2017, 11:06 PM · Frameworks
jsalatas created D4947: [KTextEditor] Expose additional internal View's functionality to the public API.
Mar 5 2017, 8:57 PM · Frameworks
jsalatas committed R39:2df4c40ea27a: Added font and on-the-fly-spellcheck options in ConfigInterface (authored by jsalatas).
Added font and on-the-fly-spellcheck options in ConfigInterface
Mar 5 2017, 10:30 AM
jsalatas closed D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface by committing R39:2df4c40ea27a: Added font and on-the-fly-spellcheck options in ConfigInterface.
Mar 5 2017, 10:30 AM · Frameworks
jsalatas added a comment to D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface.

Looks good, please commit. Do you have commit rights, or should I commit for you?

Mar 5 2017, 10:29 AM · Frameworks
jsalatas added a comment to D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface.

In general, looks good, but please also extend the documentat in src/include/configinterface.h, and add an updated patch here again :-)

Mar 5 2017, 10:15 AM · Frameworks
jsalatas updated the diff for D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface.

Added documentation for the new options in configinterface.h

Mar 5 2017, 10:12 AM · Frameworks
jsalatas created D4940: [KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface.
Mar 5 2017, 9:42 AM · Frameworks

Feb 26 2017

jsalatas committed R39:ba03878378a4: Remember file type set by user over sessions (authored by jsalatas).
Remember file type set by user over sessions
Feb 26 2017, 8:27 PM
jsalatas closed D4802: [KTextEditor] Remember file type set by user over sessions by committing R39:ba03878378a4: Remember file type set by user over sessions.
Feb 26 2017, 8:27 PM · Frameworks
jsalatas added a comment to D4491: Let make taskmanager tooltip readable again.

ElideMiddle on basic regex match for path

Feb 26 2017, 7:21 AM · Plasma
jsalatas created D4802: [KTextEditor] Remember file type set by user over sessions .
Feb 26 2017, 3:55 AM · Frameworks
jsalatas added inline comments to D4491: Let make taskmanager tooltip readable again.
Feb 26 2017, 2:52 AM · Plasma
jsalatas abandoned D4800: [Task Manager] text elide doesn't work for Tooltips.
Feb 26 2017, 2:44 AM · Plasma
jsalatas added a comment to D4800: [Task Manager] text elide doesn't work for Tooltips.
In D4800#89954, @subdiff wrote:

Removing the undefineds increases the margins between the lines again. @anthonyfieroni had another fix for the elide a few days ago by setting the maximumLineCount property. He hadn't yet pushed it though. I would go for his solution if it retains the margins. You could try if it works for you as well. It's the last revision of D4491.

Feb 26 2017, 2:44 AM · Plasma

Feb 25 2017

jsalatas added a comment to D4800: [Task Manager] text elide doesn't work for Tooltips.

If you agree, I believe this should be committed to 5.9 branch and not wait until 5.10.

Feb 25 2017, 11:45 PM · Plasma
jsalatas created D4800: [Task Manager] text elide doesn't work for Tooltips.
Feb 25 2017, 11:41 PM · Plasma
jsalatas committed R39:16d90fd266df: Reset filetype when opening url (authored by jsalatas).
Reset filetype when opening url
Feb 25 2017, 7:47 PM
jsalatas closed D4699: [KTextEditor] Reset filetype when opening url by committing R39:16d90fd266df: Reset filetype when opening url.
Feb 25 2017, 7:47 PM · Frameworks
jsalatas requested review of D4699: [KTextEditor] Reset filetype when opening url.
Feb 25 2017, 3:24 AM · Frameworks
jsalatas added a comment to D4699: [KTextEditor] Reset filetype when opening url.

Don't we need to honor "m_reloading" to avoid to do this on document reloads?

Feb 25 2017, 3:23 AM · Frameworks
jsalatas updated the diff for D4699: [KTextEditor] Reset filetype when opening url.

Honor "m_reloading" to avoid to avoid reseting the file type on document reloads as suggested by @cullmann

Feb 25 2017, 3:22 AM · Frameworks

Feb 24 2017

jsalatas added a comment to D4699: [KTextEditor] Reset filetype when opening url.

Don't we need to honor "m_reloading" to avoid to do this on document reloads?

Feb 24 2017, 7:06 AM · Frameworks
jsalatas added a comment to D4699: [KTextEditor] Reset filetype when opening url.

Looks reasonable to me as well... I don't see any negative side effects, so should be fine from my side.
@cullmann Can you confirm?

Feb 24 2017, 2:29 AM · Frameworks
jsalatas committed R39:acc3aec084d2: Added getter for word-count configuration value (authored by jsalatas).
Added getter for word-count configuration value
Feb 24 2017, 2:28 AM
jsalatas closed D4696: [KTextEditor] Reading word-count configuration value by committing R39:acc3aec084d2: Added getter for word-count configuration value.
Feb 24 2017, 2:28 AM · Frameworks, KTextEditor

Feb 23 2017

jsalatas added a comment to D4696: [KTextEditor] Reading word-count configuration value.

Indeed the getter case is missing, please commit. (Can you commit yourself, or should I take care of this?)

Feb 23 2017, 7:56 PM · Frameworks, KTextEditor

Feb 21 2017

jsalatas retitled D4699: [KTextEditor] Reset filetype when opening url from Reset filetype when opening url to [KTextEditor] Reset filetype when opening url.
Feb 21 2017, 3:22 AM · Frameworks
jsalatas created D4699: [KTextEditor] Reset filetype when opening url.
Feb 21 2017, 3:21 AM · Frameworks

Feb 20 2017

jsalatas created D4696: [KTextEditor] Reading word-count configuration value.
Feb 20 2017, 11:04 PM · Frameworks, KTextEditor
jsalatas committed R39:3b6c8b50ff1f: vimode_completion unit test failure (authored by jsalatas).
vimode_completion unit test failure
Feb 20 2017, 2:00 AM

Feb 19 2017

jsalatas committed R39:1858d6fafb58: Consistent conversion from/to cursor to/from coordinates (authored by jsalatas).
Consistent conversion from/to cursor to/from coordinates
Feb 19 2017, 7:16 PM
jsalatas closed D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates by committing R39:1858d6fafb58: Consistent conversion from/to cursor to/from coordinates.
Feb 19 2017, 7:16 PM · Frameworks, Plasma
jsalatas updated the diff for D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates.
  1. I abandoned the 3rd issue I mention in the summary about the line scrollPos(max, max.column(), calledExternally); as I could neither verify nor disprove if this was intended or not.
Feb 19 2017, 4:17 AM · Frameworks, Plasma

Feb 14 2017

jsalatas added a reviewer for D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates: KTextEditor.
Feb 14 2017, 8:29 PM · Frameworks, Plasma

Feb 12 2017

This is a test notification, sent at Sun, Feb 12, 1:49 AM.
Feb 12 2017, 9:49 AM

Feb 10 2017

jsalatas updated D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates.
Feb 10 2017, 12:48 AM · Frameworks, Plasma

Feb 9 2017

jsalatas retitled D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates from to [KTextEditor] consistent conversion from/to cursor to/from coordinates.
Feb 9 2017, 10:07 PM · Frameworks, Plasma

Jan 25 2017

jsalatas committed R246:0a5dcafef3f1: Added Greek trigram data file (authored by jsalatas).
Added Greek trigram data file
Jan 25 2017, 3:45 AM

Jan 22 2017

This is a test notification, sent at Sat, Jan 21, 5:42 PM.
Jan 22 2017, 1:42 AM
This is a test notification, sent at Sat, Jan 21, 5:42 PM.
Jan 22 2017, 1:42 AM

Jan 19 2017

jsalatas added a comment to D4197: Delete KCModule before deleting QApplication.

Seems to work.

Jan 19 2017, 2:57 AM · Plasma

Jan 18 2017

jsalatas committed R246:c7f0b1453720: Fix segfault in trigrams generation and expose MAXGRAMS constant in the header (authored by jsalatas).
Fix segfault in trigrams generation and expose MAXGRAMS constant in the header
Jan 18 2017, 9:53 PM
jsalatas closed D4181: Sonnet: segfault in trigrams generation by committing R246:c7f0b1453720: Fix segfault in trigrams generation and expose MAXGRAMS constant in the header.
Jan 18 2017, 9:53 PM · Frameworks, Plasma
jsalatas retitled D4181: Sonnet: segfault in trigrams generation from to Sonnet: segfault in trigrams generation.
Jan 18 2017, 5:01 AM · Frameworks, Plasma

Jan 16 2017

jsalatas abandoned D4153: Network manager configuration model is unreadable.
Jan 16 2017, 9:06 AM · Plasma
jsalatas added a comment to D4153: Network manager configuration model is unreadable.

BTW: I don't know how I did it but while testing it, at some point configuration didn't open at all and plasma produced the following error

Jan 16 2017, 9:03 AM · Plasma
jsalatas added a comment to D4153: Network manager configuration model is unreadable.

Icons problem solved

. Can you please test this patch?

Jan 16 2017, 9:01 AM · Plasma
jsalatas added a comment to D4153: Network manager configuration model is unreadable.

I'm trying to get rid of Plasma QML components so it uses same colors which are used by the rest of application.

Jan 16 2017, 7:40 AM · Plasma
jsalatas updated the diff for D4153: Network manager configuration model is unreadable.

Previous diff was incomplete.

Jan 16 2017, 7:28 AM · Plasma
jsalatas retitled D4153: Network manager configuration model is unreadable from to Network manager configuration model is unreadable.
Jan 16 2017, 7:24 AM · Plasma

Jan 14 2017

jsalatas committed R318:63a591f32a56: Show full path in title bar (authored by jsalatas).
Show full path in title bar
Jan 14 2017, 12:37 PM
jsalatas closed D4078: Dolphin: Show full path in title bar by committing R318:63a591f32a56: Show full path in title bar.
Jan 14 2017, 12:37 PM
jsalatas updated the diff for D4078: Dolphin: Show full path in title bar.

Updated diff as per emmanuelp's comments

Jan 14 2017, 11:54 AM

Jan 11 2017

jsalatas updated the diff for D4078: Dolphin: Show full path in title bar.

Make sure member variable declaration in the .h file is in the same order as the initializations in the constructor

Jan 11 2017, 2:51 AM
jsalatas added a reviewer for D4078: Dolphin: Show full path in title bar: Dolphin.
Jan 11 2017, 2:33 AM
jsalatas updated the test plan for D4078: Dolphin: Show full path in title bar.
Jan 11 2017, 2:33 AM
jsalatas retitled D4078: Dolphin: Show full path in title bar from to Dolphin: Show full path in title bar.
Jan 11 2017, 2:32 AM

Dec 30 2016

jsalatas committed R98:85fd0772a125: SWT/Eclipse toolbar fix (authored by jsalatas).
SWT/Eclipse toolbar fix
Dec 30 2016, 10:35 AM
jsalatas closed D3847: SWT/Eclipse toolbar fix by committing R98:85fd0772a125: SWT/Eclipse toolbar fix.
Dec 30 2016, 10:35 AM · Plasma

Dec 29 2016

jsalatas retitled D3847: SWT/Eclipse toolbar fix from to SWT/Eclipse toolbar fix.
Dec 29 2016, 7:30 AM · Plasma

Oct 6 2016

jsalatas abandoned D2913: Make the background of the logout screen darker.

I just tested it in a normal PC (ie not Virtual Machine) with 3D acceleration and the background is indeed blurred as davidedmundson said.

Oct 6 2016, 7:12 PM · Plasma

Oct 3 2016

jsalatas updated the diff for D2913: Make the background of the logout screen darker.

According to mart's suggestion there is already a rectangle, so there is no need to add a new one (the "after" screenshot is also updated to reflect this).

Oct 3 2016, 3:07 PM · Plasma

Oct 2 2016

jsalatas added a comment to D2913: Make the background of the logout screen darker.

There is no blur effect (I'm running it in a Virtual Machine with no 3D acceleration).

Oct 2 2016, 5:23 PM · Plasma