Environment variables editor: dump editable combobox, use extra name editor
ClosedPublic
Actions

Authored by kossebau on Feb 23 2017, 12:10 AM.

Details

Reviewers

apol
kfunk

Group Reviewers

KDevelop

Commits

R33:ca739ba73c11: Environment variables editor: dump editable combobox, use extra name editor
R32:ca739ba73c11: Environment variables editor: dump editable combobox, use extra name editor

Summary

Also:

use consistently term "profile" instead of "group"
mark default profile with suffix "(default profile)" in combobox list
make buttons for editing profiles icon-only, similar to other places with buttons in one row with the combobox (avoids also size issues with translated button texts)
splits the single model class into two separate model classes, one for list of profiles, one for variables of a profile
makes all UI updates (like button states) follow model signals instead of direct setting

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Feb 23 2017, 12:10 AM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 23 2017, 12:10 AM

If the term "profile" is accepted, I will do a follow-up patch to also rename the remaining classes (and places, if there are any not yet using "profile").
I did a quick search what other IDEs use for reusable environment variable sets, but could not find anything better. Proposals still welcome.

Before;

After:

I was never fond of this UI, thanks!

This revision is now accepted and ready to land.Feb 23 2017, 12:23 AM

kossebau edited the summary of this revision. (Show Details)Feb 23 2017, 12:36 AM

In D4730#88782, @apol wrote:

I was never fond of this UI, thanks!

shell/settings/environmentprofilelistmodel.h
26	Note: `EnvironmentGroupList` should be renamed as well (can be done in another commit).

Thanks!

Thanks for quick review, @apol and @kfunk.

BTW, there are still some more glitches in that dialog when it comes to variable editing, but I leave that for a later time/someone more eager to fix it now. I first would have to use this dialog some more to get a better idea what some typical workflows are.

shell/settings/environmentprofilelistmodel.h
26	Agreed, that is also the plan (cmp. also my first own comment). Patch for review coming soon to a web service near you :)

Closed by commit R33:ca739ba73c11: Environment variables editor: dump editable combobox, use extra name editor (authored by kossebau). · Explain WhyFeb 23 2017, 9:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		shell/CMakeLists.txt (3 lines)
D	M	shell/settings/environmentgroupmodel.h (80 lines)
D	M	shell/settings/environmentgroupmodel.cpp (242 lines)
M		shell/settings/environmentpreferences.h (2 lines)
M		shell/settings/environmentpreferences.cpp (10 lines)
A	M	shell/settings/environmentprofilelistmodel.h (67 lines)
A	M	shell/settings/environmentprofilelistmodel.cpp (213 lines)
A	M	shell/settings/environmentprofilemodel.h (79 lines)
A	M	shell/settings/environmentprofilemodel.cpp (237 lines)
M		shell/settings/environmentwidget.h (31 lines)
M		shell/settings/environmentwidget.cpp (312 lines)
M		shell/settings/environmentwidget.ui (54 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11651	2e39570		Feb 23 2017, 12:10 AM	★	★
Diff 2	11663	8d0c19b	R33:ca739ba73c1168abb3fe8bad702e4d87810c4152	Feb 23 2017, 9:38 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
7d5fe55ab597	e1aea8781150	2e395709921b	Friedrich W. H. Kossebau	Environment variables editor: dump editable combobox, use extra name editor (Show More…)	Feb 23 2017, 12:09 AM