Differential D4712

Ungrab mouse on menu close
ClosedPublic
Actions

Authored by anthonyfieroni on Feb 21 2017, 7:11 PM.

Details

Reviewers
mart
broulik
davidedmundson
Group Reviewers
Plasma
Summary

Same as plasma-framework, on audio volume is weird as hell. Right click -> settings -> click in config window :)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
anthonyfieroni created this revision.Feb 21 2017, 7:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2017, 7:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni updated this revision to Diff 11880.Feb 27 2017, 7:59 AM

To commit it later today ?

davidedmundson added a subscriber: davidedmundson.Apr 19 2017, 8:57 PM

Well, now that I understand the bug, I would say this isn't right.

If I dismiss the menu by clicking something else in the original qtquick scene, the events won't happen in the order you want.

anthonyfieroni added a comment.Apr 20 2017, 6:32 AM

Why QTimer is better solution?

anthonyfieroni updated this revision to Diff 14487.May 13 2017, 7:02 PM
anthonyfieroni added a reviewer: davidedmundson.
anthonyfieroni removed a subscriber: davidedmundson.

Still happens in systray

davidedmundson accepted this revision.May 13 2017, 7:51 PM
This revision is now accepted and ready to land.May 13 2017, 7:51 PM
anthonyfieroni added a comment.May 14 2017, 2:50 AM

Arrgh, It's pushed by you in all cases but it should be

QVersionNumber::fromString(qVersion()) >= QVersionNumber(5, 8, 0)

However 5.8.0 it's not affected by the hack :)

Revision Contents
Changeset List

PathPackages
Mapplets/systemtray/systemtray.cpp (26 lines)

Diff 14487

View Options

applets/systemtray/systemtray.cpp

Loading...