Differential D4630

Only register APPLE_* options if(APPLE)
ClosedPublic
Actions

Authored by apol on Feb 16 2017, 11:56 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R240:9d3abb5c88f9: Only register APPLE_* options if(APPLE)
Summary

Otherwise the cmake cache has noisy values.

Test Plan

Recreated a project, it's not listed first thing when calling ccmake.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 11401.Feb 16 2017, 11:56 AM
apol retitled this revision from to Only register APPLE_* options if(APPLE).
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptFeb 16 2017, 11:56 AM
Restricted Application added a subscriber: Build System. · View Herald Transcript
apol added a comment.Mar 3 2017, 11:30 PM

If nobody reviews I'll push during the next week.

dfaure accepted this revision.Mar 4 2017, 9:53 AM
This revision is now accepted and ready to land.Mar 4 2017, 9:53 AM
Closed by commit R240:9d3abb5c88f9: Only register APPLE_* options if(APPLE) (authored by apol). · Explain WhyMar 5 2017, 11:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkde-modules/KDECMakeSettings.cmake (31 lines)

Diff 12205

View Options

kde-modules/KDECMakeSettings.cmake

Loading...