Differential D4619

Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter
ClosedPublic
Actions

Authored by atomsymbol on Feb 15 2017, 2:12 PM.

Details

Reviewers
mwolff
dhaumann
kfunk
Commits
R39:9b0d8dce4977: Printing: Respect footer font, fix footer vertical position, make header/footer…
Summary

Fixes bug 376060 (https://bugs.kde.org/show_bug.cgi?id=376060).

Test Plan

Tested with:

  • Print to PDF
  • Print to local printer

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atomsymbol updated this revision to Diff 11367.Feb 15 2017, 2:12 PM
atomsymbol retitled this revision from to Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter.
atomsymbol updated this object.
atomsymbol edited the test plan for this revision. (Show Details)
atomsymbol added a reviewer: kfunk.
atomsymbol set the repository for this revision to R39 KTextEditor.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 15 2017, 2:12 PM
Restricted Application added subscribers: Frameworks, kwrite-devel. · View Herald Transcript
dhaumann requested changes to this revision.Feb 21 2017, 8:58 PM
dhaumann added a subscriber: dhaumann.

I tested this patch: I think, the footer's height is not correct when the box is disabled, see: http://i.imgur.com/Te5XigY.png
When the box is activated, it has the same height as the header. I think it should always have the same height.

Could you have a look again?

This revision now requires changes to proceed.Feb 21 2017, 8:58 PM
dhaumann added a comment.Aug 22 2017, 8:16 PM

@atomsymbol I would love to get this into KTextEditor. Would you mind having another look?

dhaumann accepted this revision.Aug 13 2018, 9:46 AM

Tested again, certainly an improvement. If we find more issues, we can still improve.

This revision is now accepted and ready to land.Aug 13 2018, 9:46 AM
Restricted Application added a project: Kate. · View Herald TranscriptAug 13 2018, 9:46 AM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald Transcript
Closed by commit R39:9b0d8dce4977: Printing: Respect footer font, fix footer vertical position, make header/footer… (authored by dhaumann). · Explain WhyAug 13 2018, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/printing/printpainter.cpp (14 lines)

Diff 39573

View Options

src/printing/printpainter.cpp

Loading...