Avoid utimes() in custommake projects, remove unsermake support
ClosedPublic

Authored by atomsymbol on Feb 14 2017, 5:46 PM.

Details

Summary

The patch should at least partially fix https://bugs.kde.org/show_bug.cgi?id=376432

Remaining traces of unsermake support in KDevelop: There's a single "unsermake" string in cmakeasttest.cpp.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atomsymbol updated this revision to Diff 11345.Feb 14 2017, 5:46 PM
atomsymbol retitled this revision from to Avoid utimes() in custommake projects which aren't based not unsermake.
atomsymbol updated this object.
atomsymbol edited the test plan for this revision. (Show Details)
atomsymbol added a reviewer: kfunk.
atomsymbol set the repository for this revision to R32 KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 14 2017, 5:46 PM
brauch added a subscriber: brauch.Feb 14 2017, 8:49 PM

Thanks -- but IMO remove the unsermake stuff altogether while we're at it. It's dead.

atomsymbol retitled this revision from Avoid utimes() in custommake projects which aren't based not unsermake to Avoid utimes() in custommake projects, remove unsermake support.
atomsymbol updated this object.
mwolff accepted this revision.Feb 15 2017, 7:10 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm

This revision is now accepted and ready to land.Feb 15 2017, 7:10 PM
kfunk edited edge metadata.Feb 17 2017, 7:54 AM
kfunk added a subscriber: zwabel.

@zwabel Opinions about this patch? Yay or nay?

Some context from what I remember:

  • this feature used to be required to ensure make is always fully executed
  • I don't know why we don't simply rely on make --always-make instead
  • maybe because of unsermake, I don't even know what that is or whether its used
  • the file modificiation time wrapper caused us tons of issues already
  • we removed it from cmake/qmake to great effect

So, again, from my side a clear +1 for this patch

@atomsymbol: Do you have commit rights? If not, what is your email address that I can use for the git commit?

Thanks

@mwolff: I don't have commit rights. The email address is available at http://atom-symbol.net/email.html

@mwolff: I don't have commit rights. The email address is available at http://atom-symbol.net/email.html

You are aware that this email will be associated with your git commit, and thus readable in plain text? I wonder why you put an image up there, when your mail address is visible in plain text e.g. here: https://github.com/atomsymbol and soon in KDE as well?

This revision was automatically updated to reflect the committed changes.
kfunk added a comment.Feb 20 2017, 9:07 PM

Thanks for the patch, Jan. Way to go!

In D4612#88020, @mwolff wrote:

I wonder why you put an image up there, when your mail address is visible in plain text e.g. here: https://github.com/atomsymbol and soon in KDE as well?

There's no particular reason behind it being an image. It's a PNG image now, it might be in text form in the future.