Differential D4593

Standardize on "Executable" in UI & API, do not mix with "Binary"
ClosedPublic
Actions

Authored by kossebau on Feb 13 2017, 1:02 AM.

Details

Reviewers

apol

Group Reviewers

KDevelop

Commits

R32:691f9c461bd0: Standardize on "Executable" in UI & API, do not mix with "Binary"

Summary

For UI:

KDevelop supports both scripting and compiled languages, so e.g. debugging target can be non-binary
external tools might be known as binary-only, but sometimes they are inside wrapper scripts and no place really requires a compiled binary
consistent terms help users & also translators

For API/variable names:

"executable" matches API of Qt
consistent with UI language

Config storage keys not touched for now, might need more thinking.

Depends on D4592

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 11271.Feb 13 2017, 1:02 AM

kossebau retitled this revision from to Standardize on "Executable" in UI & API, do not mix with "Binary".

kossebau updated this object.

kossebau added a reviewer: KDevelop.

kossebau added a dependency: D4592: Standardize on "Executable" in UI & API, do not mix with "Binary".

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 13 2017, 1:02 AM

apol accepted this revision.Feb 13 2017, 10:52 AM

apol added a reviewer: apol.

This revision is now accepted and ready to land.Feb 13 2017, 10:52 AM

flherne added a subscriber: flherne.Feb 13 2017, 11:17 AM

flherne added inline comments.

debuggers/common/midebugger.h
138	Perhaps this should be debuggerExecutable_ for consistency within the class?
projectmanagers/cmake/tests/testhelpers.h
36	The QMake one has a //TODO

kossebau added inline comments.Feb 13 2017, 4:54 PM

debuggers/common/midebugger.h
138	Good question. So far I was assuming that while touching lines the content would get transformed to latest coding style, even if then being inconsistent with the older neighbourhood. Will also poke devs on irc to get a +1/-1 on this.
projectmanagers/cmake/tests/testhelpers.h
36	Well, spotted, +1 for closely reading all changes :) Would add a TODO to all such places on pushing.

Closed by commit R32:691f9c461bd0: Standardize on "Executable" in UI & API, do not mix with "Binary" (authored by kossebau). · Explain WhyFeb 14 2017, 6:18 AM

This revision was automatically updated to reflect the committed changes.

kossebau marked an inline comment as done.

Revision Contents
Changeset List

			Path	Packages
M			app/kdevideextension.h (2 lines)
M			app/kdevideextension.cpp (2 lines)
M			app/main.cpp (18 lines)
M			debuggers/common/dialogs/selectcoredialog.h (2 lines)
M			debuggers/common/dialogs/selectcoredialog.cpp (4 lines)
M			debuggers/common/dialogs/selectcoredialog.ui (2 lines)
M			debuggers/common/midebugger.h (2 lines)
M			debuggers/common/midebugger.cpp (4 lines)
M			debuggers/common/midebugjobs.cpp (2 lines)
M			debuggers/gdb/gdb.cpp (16 lines)
M			debuggers/gdb/gdbconfigpage.ui (2 lines)
M			debuggers/lldb/lldbdebugger.cpp (10 lines)
M			languages/plugins/custom-definesandincludes/compilerprovider/widget/compilerswidget.ui (2 lines)
M			projectbuilders/cmakebuilder/cmakebuilderconfig.kcfg (2 lines)
M			projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp (6 lines)
M			projectbuilders/cmakebuilder/cmakebuilderpreferences.ui (2 lines)
M			projectbuilders/cmakebuilder/cmakejob.cpp (2 lines)
M			projectbuilders/makebuilder/makebuilderconfig.kcfg (5 lines)
M			projectbuilders/makebuilder/makebuilderpreferences.h (2 lines)
M			projectbuilders/makebuilder/makebuilderpreferences.cpp (14 lines)
M			projectbuilders/makebuilder/makeconfig.ui (4 lines)
M			projectbuilders/makebuilder/makejob.cpp (3 lines)
M			projectbuilders/ninjabuilder/kdevninjabuilderplugin.cpp (2 lines)
M			projectbuilders/ninjabuilder/ninjajob.h (2 lines)
M			projectbuilders/ninjabuilder/ninjajob.cpp (4 lines)
M			projectbuilders/qmakebuilder/qmakejob.cpp (2 lines)
M			projectmanagers/cmake/cmakebuilddirchooser.h (4 lines)
M			projectmanagers/cmake/cmakebuilddirchooser.cpp (14 lines)
M			projectmanagers/cmake/cmakebuilddirchooser.ui (6 lines)
M			projectmanagers/cmake/cmakedocumentation.h (2 lines)
M			projectmanagers/cmake/cmakedocumentation.cpp (10 lines)
M			projectmanagers/cmake/cmakemanager.cpp (2 lines)
M			projectmanagers/cmake/cmakeutils.h (10 lines)
M			projectmanagers/cmake/cmakeutils.cpp (25 lines)
M			projectmanagers/cmake/settings/cmakebuildsettings.ui (6 lines)
M			projectmanagers/cmake/settings/cmakepreferences.cpp (16 lines)
M			projectmanagers/cmake/tests/testhelpers.h (4 lines)
M			projectmanagers/qmake/qmakebuilddirchooser.h (4 lines)
M			projectmanagers/qmake/qmakebuilddirchooser.cpp (32 lines)
M			projectmanagers/qmake/qmakebuilddirchooser.ui (8 lines)
M			projectmanagers/qmake/qmakebuilddirchooserdialog.cpp (2 lines)
M			projectmanagers/qmake/qmakeconfig.h (8 lines)
M			projectmanagers/qmake/qmakeconfig.cpp (15 lines)
M			projectmanagers/qmake/qmakemanager.cpp (2 lines)
M			projectmanagers/qmake/qmakeprojectfile.cpp (12 lines)
M			projectmanagers/qmake/qmakeutils.cpp (6 lines)
M			projectmanagers/qmake/tests/qmaketestconfig.h.in (2 lines)
M			projectmanagers/qmake/tests/test_qmakefile.cpp (2 lines)
M			projectmanagers/qmake/tests/test_qmakeproject.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11271	b2487ac		Feb 13 2017, 1:02 AM	★	★
Diff 2	11319	cb19872	R32:691f9c461bd0354ab2085e972562f1f8a218ca6e	Feb 14 2017, 6:18 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
1cd5e6de8965	76aaf4672e30	b2487ac54f51	Friedrich W. H. Kossebau	Standardize on "Executable" in UI & API, do not mix with "Binary" (Show More…)	Feb 13 2017, 1:01 AM

	Status	Author	Revision
	Closed	kossebau	D4593 Standardize on "Executable" in UI & API, do not mix with "Binary"
	Closed	kossebau	D4592 Standardize on "Executable" in UI & API, do not mix with "Binary"