Differential D4591

[Widget Explorer] Remove pointless QSignalMapper
ClosedPublic
Actions

Authored by broulik on Feb 12 2017, 10:49 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:e6dc96f30c4a: [Widget Explorer] Remove pointless QSignalMapper
Summary

We no longer have the ability to install different applet types. Even if we had, we could just use a lambda nowadays.

Test Plan

Both GHNS and install from file still trigger.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 11265.Feb 12 2017, 10:49 PM
broulik retitled this revision from to [Widget Explorer] Remove pointless QSignalMapper.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 12 2017, 10:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 12 2017, 10:57 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

btw, if you have this code open to set the transient parent on the WE wialogs, I started that and it's not trivial.

This revision is now accepted and ready to land.Feb 12 2017, 10:57 PM
Closed by commit R120:e6dc96f30c4a: [Widget Explorer] Remove pointless QSignalMapper (authored by broulik). · Explain WhyFeb 13 2017, 12:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11265

View Options

components/shellprivate/widgetexplorer/widgetexplorer.h

Loading...
View Options

components/shellprivate/widgetexplorer/widgetexplorer.cpp

Loading...