[Widget Explorer] Remove pointless QSignalMapper
ClosedPublic
Actions

Authored by broulik on Feb 12 2017, 10:49 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

Summary

We no longer have the ability to install different applet types. Even if we had, we could just use a lambda nowadays.

Test Plan

Both GHNS and install from file still trigger.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Widget Explorer] Remove pointless QSignalMapper.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R120 Plasma Workspace.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

btw, if you have this code open to set the transient parent on the WE wialogs, I started that and it's not trivial.

This revision is now accepted and ready to land.Feb 12 2017, 10:57 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			components/shellprivate/widgetexplorer/widgetexplorer.h (2 lines)
M			components/shellprivate/widgetexplorer/widgetexplorer.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11265			Feb 12 2017, 10:48 PM	★	★
Diff 2	11281	126fc2f	R120:e6dc96f30c4a5864ee88c1bd929370909f88208f	Feb 13 2017, 12:17 PM	★	★