Differential D457

Fix Bug #307107 (Kate does not save and reflect disabling background color settings for highlighting)
ClosedPublic
Actions

Authored by senkovych on Oct 28 2015, 5:48 PM.

Details

Reviewers
dhaumann
cullmann
kfunk
Group Reviewers
KTextEditor
Commits
R39:4e1fb2a5f1c7: Fix bug #307107
Summary

Naming issue: enum items from KateStyleTreeWidgetItem::columns had same names as CustomProperties and were used for getting text attribute properties.

Test Plan

Successfully saved background color settings after applying a patch

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
senkovych updated this revision to Diff 1070.Oct 28 2015, 5:48 PM
senkovych retitled this revision from to Fix Bug #307107 (Kate does not save and reflect disabling background color settings for highlighting).
senkovych updated this object.
senkovych edited the test plan for this revision. (Show Details)
senkovych added reviewers: KTextEditor, hein.
senkovych set the repository for this revision to R39 KTextEditor.
senkovych added a project: KTextEditor.
senkovych edited reviewers, added: kfunk; removed: hein.Oct 29 2015, 9:56 AM
cullmann added a subscriber: cullmann.EditedOct 29 2015, 9:57 AM

Looks good for me ;=)

kfunk accepted this revision.Oct 29 2015, 9:58 AM
kfunk added a reviewer: dhaumann.
kfunk edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 29 2015, 9:59 AM
cullmann accepted this revision.Oct 29 2015, 9:59 AM
cullmann added a reviewer: cullmann.

Commit that, I dislike that we have the name clash at all, which is not that nice, but at least this is a minimal intrusive fix for the issue.
Thanks for the patch!

dhaumann accepted this revision.Oct 29 2015, 10:12 AM
dhaumann edited edge metadata.

Yes, please commit.

Closed by commit R39:4e1fb2a5f1c7: Fix bug #307107 (authored by senkovych, committed by kfunk). · Explain WhyOct 29 2015, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/schema/katestyletreewidget.cpp (24 lines)

Diff 1085

View Options

src/schema/katestyletreewidget.cpp

Loading...