Differential D4564

KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 11 2017, 11:32 AM.

Details

Reviewers
cfeck
Commits
R236:8ab5a291e855: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero
Summary

Otherwise the tooltip will stay visible when the mouse cursor (by accident) hovers it.
This is unexpected because a zero hide delay is supposed to mean "hide immediately".

Test Plan

manual test

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 11209.Feb 11 2017, 11:32 AM
elvisangelaccio retitled this revision from to KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: cfeck.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 11 2017, 11:32 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
cfeck edited edge metadata.Feb 13 2017, 7:34 PM

Does calling setHideDelay(0) also need to immediately hide()?

elvisangelaccio added a comment.Feb 13 2017, 11:12 PM
In D4564#86076, @cfeck wrote:

Does calling setHideDelay(0) also need to immediately hide()?

It seems not necessary, setHideDelay(0) will set a 0 interval on the timer, which causes timeout to be emitted (and this signal is already connected to hide()).

cfeck accepted this revision.Feb 14 2017, 1:27 AM
cfeck edited edge metadata.
This revision is now accepted and ready to land.Feb 14 2017, 1:27 AM
Closed by commit R236:8ab5a291e855: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero (authored by elvisangelaccio). · Explain WhyFeb 14 2017, 9:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ktooltipwidget.cpp (8 lines)

Diff 11326

View Options

src/ktooltipwidget.cpp

Loading...