Differential D4560

Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart
ClosedPublic
Actions

Authored by vishalrao on Feb 11 2017, 5:38 AM.

Details

Reviewers
emmanuelp
elvisangelaccio
Group Reviewers
VDG
Commits
R318:58c5eae1953b: Increase smooth scrolling animation duration from 100 to 300 ms and set easing…
Summary

The current animation duration for smooth scrolling is 100 ms which feels as if there is no smooth scroll animation in the first place. Bumping this up to something like 300 ms seems to make the scrolling actually appear smooth.

Also, based on diff comments the easing curve is set to InOutQuart.

Test Plan

Built this change locally and tried scrolling a folder with many items both single step mouse wheel and also larger steps of the mouse wheel.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vishalrao updated this revision to Diff 11201.Feb 11 2017, 5:38 AM
vishalrao retitled this revision from to Increase smooth scrolling animation duration from 100 to 500 ms.
vishalrao updated this object.
vishalrao edited the test plan for this revision. (Show Details)
vishalrao set the repository for this revision to R318 Dolphin.
emmanuelp edited edge metadata.EditedFeb 18 2017, 11:51 PM

Thanks for the patch!

I think that 500ms is too much. I would set it to 300ms and maybe also set the animation easing curve to e.g. InOutQuart (personal taste), with these changes it feels like my web browser.
I have also googled a little bit about research papers about this topic but I couldn't find anything useful.

VDG what do you think?

@htietze @colomar @andreask

vishalrao added a comment.Feb 20 2017, 7:27 AM

Thank you for the comment! I guess, yeah 300 ms and InOutQuart would look good to me too.

Looking for comments from VDG team. Do I need to do anything right now? Maybe update the patch or create a video to demonstrate the change visually or something like that? Or do you folks try this patch locally to see for yourself how Dolphin looks and feels with the change?

Thanks again.

emmanuelp added a comment.Feb 22 2017, 4:22 PM
In D4560#87675, @vishalrao wrote:

I guess, yeah 300 ms and InOutQuart would look good to me too.

Perfect :)
Can you please apply these changes?

vishalrao updated this revision to Diff 11657.Feb 23 2017, 4:52 AM
vishalrao retitled this revision from Increase smooth scrolling animation duration from 100 to 500 ms to Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart.
vishalrao edited the summary of this revision. (Show Details)

Update diff to set duration to 300 ms instead of 500 ms and set easing curve to InOutQuart.

emmanuelp accepted this revision.Feb 23 2017, 3:02 PM

Thanks!

Do you have commit access?

This revision is now accepted and ready to land.Feb 23 2017, 3:02 PM
vishalrao added a comment.Feb 24 2017, 4:15 AM

Nope, I don't have commit access, so will need someone with that to commit this.

Closed by commit R318:58c5eae1953b: Increase smooth scrolling animation duration from 100 to 300 ms and set easing… (authored by vishalrao, committed by elvisangelaccio). · Explain WhyFeb 26 2017, 10:53 PM
This revision was automatically updated to reflect the committed changes.
andreaska added a subscriber: andreaska.Mar 8 2017, 2:05 PM

I can't give you any feedback, sorry that I can't help, but I don't know how to review it and how to help.

broulik added a reviewer: VDG.Mar 8 2017, 2:08 PM

Revision Contents
Changeset List

Diff 11867

View Options

src/kitemviews/private/kitemlistsmoothscroller.cpp

Loading...