Differential D4557

Fix gtk-primary-button-warps-slider with GTK 2
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 10 2017, 10:48 PM.

Details

Reviewers
apol
broulik
Commits
R99:4a06c4d34f2d: Fix gtk-primary-button-warps-slider with GTK 2
Summary

Replace true/false with 1/0. The former works only with GTK 3, but
breaks with GTK 2 apps.

BUG: 376273
FIXED-IN: 5.8.6

Test Plan

Tested with inkscape (which is gtk2); still works with gtk3 apps.

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Branch
Plasma/5.8
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 11195.Feb 10 2017, 10:48 PM
elvisangelaccio retitled this revision from to Fix gtk-primary-button-warps-slider with GTK 2.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added reviewers: apol, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 10 2017, 10:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Feb 10 2017, 10:48 PM
broulik edited edge metadata.

I thought it was only GTK 3 apps that did that, but fair enough

This revision is now accepted and ready to land.Feb 10 2017, 10:48 PM
Closed by commit R99:4a06c4d34f2d: Fix gtk-primary-button-warps-slider with GTK 2 (authored by elvisangelaccio). · Explain WhyFeb 10 2017, 10:56 PM
This revision was automatically updated to reflect the committed changes.
apol edited edge metadata.Feb 13 2017, 1:12 AM

Looks to me like it needs both alternatives? Something like bool isTrue(const QString &f) { return f=="1" || f=="true"; }

Revision Contents
Changeset List

PathPackages
Msrc/abstractappearance.cpp (4 lines)

Diff 11195

View Options

src/abstractappearance.cpp

Loading...