Fix gtk-primary-button-warps-slider with GTK 2
ClosedPublic

Authored by elvisangelaccio on Feb 10 2017, 10:48 PM.

Details

Summary

Replace true/false with 1/0. The former works only with GTK 3, but
breaks with GTK 2 apps.

BUG: 376273
FIXED-IN: 5.8.6

Test Plan

Tested with inkscape (which is gtk2); still works with gtk3 apps.

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Fix gtk-primary-button-warps-slider with GTK 2.Feb 10 2017, 10:48 PM
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added reviewers: apol, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 10 2017, 10:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Feb 10 2017, 10:48 PM

I thought it was only GTK 3 apps that did that, but fair enough

This revision is now accepted and ready to land.Feb 10 2017, 10:48 PM
This revision was automatically updated to reflect the committed changes.
apol added a comment.Feb 13 2017, 1:12 AM

Looks to me like it needs both alternatives? Something like bool isTrue(const QString &f) { return f=="1" || f=="true"; }