Differential D4502

[Settings Dialog] Show Trash settings only if authorized
ClosedPublic
Actions

Authored by broulik on Feb 8 2017, 2:22 PM.

Details

Reviewers
emmanuelp
Group Reviewers
Dolphin
Commits
R318:333e2ae031fe: [Settings Dialog] Show Trash settings only if authorized
Summary

If this KCM is disabled through KIOSK restriction opening it would result in an error message.
Hide the entry altogether in this case.

Test Plan

Originally posted as https://git.reviewboard.kde.org/r/127955 but with comments addressed.

Put the following in kdeglobals

[KDE Control Module Restrictions]
kcmtrash.desktop=false

and the Trash setting in Dolphin was gone. Without that restriction it still shows up and changing a setting there enables the Apply button

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 11065.Feb 8 2017, 2:22 PM
broulik retitled this revision from to [Settings Dialog] Show Trash settings only if authorized.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Dolphin.
broulik set the repository for this revision to R318 Dolphin.
emmanuelp accepted this revision.Feb 8 2017, 2:33 PM
emmanuelp added a reviewer: emmanuelp.
emmanuelp added a subscriber: emmanuelp.

Nice!

This revision is now accepted and ready to land.Feb 8 2017, 2:33 PM
Closed by commit R318:333e2ae031fe: [Settings Dialog] Show Trash settings only if authorized (authored by broulik). · Explain WhyFeb 8 2017, 3:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11069

View Options

src/settings/dolphinsettingsdialog.h

Loading...
View Options

src/settings/dolphinsettingsdialog.cpp

Loading...