| mlaurent | |
| vkrause |
| KDE PIM |
it is not a joke, that you can delete the code after June 2016!
We only need the code to read once the old vacation script,
afterwards we can delete it.
If you try to load the old script with the new script extractor, you loose only
react on spam, excluded domain and start/end date. So not every information is lost.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.h | ||
|---|---|---|
| 19 | Remove all these TODO | |
| libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.h | ||
|---|---|---|
| 19 |
See vacationutils:222 if (vacation.sendForSpam && vacation.excludeDomain.isEmpty() && !vacation.startDate.isValid() && !vacation.endDate.isValid()) {
const auto vac = parseScriptLegacy(script); | |
it's not a big problem to keep it until kdepim 6 ? no ?
is it critical to keep it after 06-2016 ?
There is a dead line ?
No there is no dealine or anything in 06-2016, we can leave the code for ever.
The point I was discussing with @vkrause, that it would be nice to remove dead code as fast as possible and also make it clear in the code, that this code is only a temporary needed. Without an explicit message, we will forget to delete this. If you have a better solution, how to mark such code...
And 8 month came from, that we have at least two KDE Applications in between.
For me it's not a dead code it's a "migrate" code and I know some guy as David Faure for example which didn't switch to kf5 yet (for kdepim).
And his wife will wait more time.
So I don't know what is a problem to keep it until kf6.
| libksieve/src/ksieveui/vacation/legacy/README | ||
|---|---|---|
| 4 | to new one | |
/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.h:297:25: warning: unused parameter ‘lineNumber’ [-Wunused-parameter]
void blockStart(int lineNumber) Q_DECL_OVERRIDE {}
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.h:298:23: warning: unused parameter ‘lineNumber’ [-Wunused-parameter]
void blockEnd(int lineNumber) Q_DECL_OVERRIDE {}
^In file included from /stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.cpp:18:0:
/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.h:297:25: warning: unused parameter ‘lineNumber’ [-Wunused-parameter]
void blockStart(int lineNumber) Q_DECL_OVERRIDE {}
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.h:298:23: warning: unused parameter ‘lineNumber’ [-Wunused-parameter]
void blockEnd(int lineNumber) Q_DECL_OVERRIDE {}
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.cpp:34:91: warning: unused parameter ‘lineNumber’ [-Wunused-parameter]
void KSieveUi::Legacy::VacationDataExtractor::commandStart(const QString &identifier, int lineNumber)
^
/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/legacy/vacationscriptextractor.cpp:44:62: warning: unused parameter ‘lineNumber’ [-Wunused-parameter]
void KSieveUi::Legacy::VacationDataExtractor::commandEnd(int lineNumber)
^
I have 2 kolabs accounts.
So I can't use it in kmail.
never tests with 2 accounts :P replaces the ASSERT with a if clause to deside to to further or not. see D446