Details
- Reviewers
mlaurent vkrause - Group Reviewers
KDE PIM - Maniphest Tasks
- T718: Upsteam KEP:14 support for libsieve
- Commits
- R43:c49f6bfcb543: Use struct to parse/read vacation script.
Diff Detail
- Repository
- R43 KDE PIM
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| libksieve/src/ksieveui/vacation/vacationutils.cpp | ||
|---|---|---|
| 205 | This seems unused? | |
| libksieve/src/ksieveui/vacation/autotests/vacationutilstest.cpp | ||
|---|---|---|
| 35 | const int l1count = l1.count(); > avoid to recall it. | |
| libksieve/src/ksieveui/vacation/vacationutils.cpp | ||
| 163–166 | you "parse" twice ? | |
| 377 | const | |
| 388 | const | |
| 475 | const QString &scriptupdate | |
| 503 | ++i | |
| 513 | const int requirementcount = requirements.count(), | |
| libksieve/src/ksieveui/vacation/autotests/vacationutilstest.cpp | ||
|---|---|---|
| 306 | ++i | |
| 311 | ++i | |
| libksieve/src/ksieveui/vacation/vacationutils.cpp | ||
| 317 | move this line after the if (scriptUtf8.isEmpty()) not necessary to generate scriptUpdateUtf8 if we will not use it. | |
| 318 | Better to write all in one line and not 3. | |
| 323 | isEmpty() | |
| 394 | ++i | |
| libksieve/src/ksieveui/vacation/autotests/CMakeLists.txt | ||
|---|---|---|
| 18 | Are you sure that "\\" is still necessary in kf5 ? | |
| libksieve/src/ksieveui/vacation/vacationutils.cpp | ||
| 185 | why QString::fromAscii(...).toUtf8() ? why not QByteArray directly ? QByteArrayLiteral ? | |
| 253 | remove space between begin() and ";" | |
| libksieve/src/ksieveui/vacation/autotests/CMakeLists.txt | ||
|---|---|---|
| 18 | well if using set_target_properties: yes, but switching to add_defintion there is no need to use it anymore. | |
/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationcheckjob.cpp: In member function ‘void KSieveUi::VacationCheckJob::slotGetResult(KManageSieve::SieveJob*, bool, const QString&, bool)’:
/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationcheckjob.cpp:55:9: warning: unused variable ‘dummyInt’ [-Wunused-variable]
int dummyInt;
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationcheckjob.cpp:56:10: warning: unused variable ‘dummyBool’ [-Wunused-variable]
bool dummyBool;
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp: In function ‘KSieveUi::VacationUtils::Vacation KSieveUi::VacationUtils::parseScript(const QString&)’:
/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:163:33: error: ‘class KSieveUi::VacationDataExtractor’ has no member named ‘commandFound’
if (!parser.parse() || !vdx.commandFound()) {
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:169:27: error: ‘class KSieveUi::VacationDataExtractor’ has no member named ‘active’
vacation.active = vdx.active();
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:170:31: error: ‘class KSieveUi::VacationDataExtractor’ has no member named ‘mailAction’
vacation.mailAction = vdx.mailAction();
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:171:40: error: ‘class KSieveUi::VacationDataExtractor’ has no member named ‘mailActionRecipient’
vacation.mailActionRecipient = vdx.mailActionRecipient();
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:184:34: error: ‘class KSieveUi::VacationDataExtractor’ has no member named ‘ifComment’
if (!vacation.active && !vdx.ifComment().isEmpty()) {
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:185:69: error: ‘class KSieveUi::VacationDataExtractor’ has no member named ‘ifComment’
const QByteArray newScript = QByteArrayLiteral("if ") + vdx.ifComment().toUtf8() + QByteArrayLiteral("{vacation;}");
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:199:29: error: ‘class KSieveUi::DateExtractor’ has no member named ‘startTime’
vacation.startTime = dx.startTime();
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:201:27: error: ‘class KSieveUi::DateExtractor’ has no member named ‘endTime’
vacation.endTime = dx.endTime();
^/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp: In function ‘QString KSieveUi::VacationUtils::mergeRequireLine(const QString&, const QString&)’:
/stockage/kde5/kdepim/libksieve/src/ksieveui/vacation/vacationutils.cpp:330:5: error: ‘RequireExtractor’ was not declared in this scope
impossible to test compile for it.
I will add more patch now.