Differential D4448

Don't use tier3 frameworks in unit tests
ClosedPublic
Actions

Authored by svuorela on Feb 5 2017, 4:06 PM.

Details

Reviewers
sitter
kde-frameworks-devel
vonreth
dfaure
Commits
R266:b42483f4cbdb: Rewrite tests to not use tier3 frameworks
Summary

Port away from tier2 and 3 frameworks in the unit tests

Test Plan

Tests still passes

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
svuorela updated this revision to Diff 10942.Feb 5 2017, 4:06 PM
svuorela retitled this revision from to Don't use tier3 frameworks in unit tests.
svuorela updated this object.
svuorela edited the test plan for this revision. (Show Details)
svuorela added reviewers: sitter, vonreth, kde-frameworks-devel.
svuorela set the repository for this revision to R266 Breeze Icons.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 5 2017, 4:06 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Feb 12 2017, 8:45 AM
dfaure added a reviewer: dfaure.
This revision is now accepted and ready to land.Feb 12 2017, 8:45 AM
sitter accepted this revision.Feb 14 2017, 10:47 AM
sitter edited edge metadata.

Ah! I hadn't even thought of QSettings. Love the change.

FWIW if you fancy more work: seeing as the test now has its own enums you could align the Context enum values' names with their string representation allowing parseContext to work like parseType by letting the metaobject do the mapping.

Closed by commit R266:b42483f4cbdb: Rewrite tests to not use tier3 frameworks (authored by svuorela). · Explain WhyFeb 14 2017, 8:47 PM
This revision was automatically updated to reflect the committed changes.
svuorela mentioned this in R266:b42483f4cbdb: Rewrite tests to not use tier3 frameworks.

Revision Contents
Changeset List

PathPackages
Mautotests/CMakeLists.txt (20 lines)
Mautotests/scalabletest.cpp (157 lines)

Diff 11351

View Options

autotests/CMakeLists.txt

Loading...
View Options

autotests/scalabletest.cpp

Loading...