Add KUrlRequester::setMimeTypeFilters.
ClosedPublic
Actions

Authored by dfaure on Feb 4 2017, 5:52 PM.

Details

Reviewers

mlaurent
markg

Commits

R241:4f8e9f45c600: Add KUrlRequester::setMimeTypeFilters.

Summary

Otherwise people need to call the deprecated fileDialog() method to set it,
which creates the file dialog too early.

Test Plan

It compiles.

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure retitled this revision from to Add KUrlRequester::setMimeTypeFilters..

dfaure updated this object.

dfaure edited the test plan for this revision. (Show Details)

dfaure added a reviewer: mlaurent.

dfaure added a subscriber: Frameworks.

Looks good to me.

This revision is now accepted and ready to land.Feb 4 2017, 6:44 PM

This revision was automatically updated to reflect the committed changes.

cfeck added inline comments.

src/widgets/kurlrequester.h
144	The APIDOX for these two functions are somehow swapped.

dfaure marked an inline comment as done.Feb 5 2017, 9:38 AM

dfaure added inline comments.

src/widgets/kurlrequester.h
144	Thanks for noticing, fixed.

			Path	Packages
M			src/widgets/kurlrequester.h (13 lines)
M			src/widgets/kurlrequester.cpp (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10912	b158255		Feb 4 2017, 5:52 PM	★	★
Diff 2	10914	c9cbe63	R241:4f8e9f45c600ea6f246fcf3b84a7adc7792276bc	Feb 4 2017, 7:16 PM	★	★