use proper packagestructures
ClosedPublic

Authored by mart on Jan 19 2017, 5:21 PM.

Details

Summary

as the plasmapkg2 utility is dead, scripts and tabboxes couldn't
be installed anymore, as plasmapkg2 was launched with an hardcoded
package type (and had a bunch of custom code for it)
and no packagestructure for the relevant package types existed.

the port of scripts and tabboxes to kpackage in kwin is quite
incomplete and somewhat strange (given the fact that was started by
looking manually for the file as it couldn't link to libplasma)

this makes things a bit better as now scripts and tabboxes have an actual
package structure, making it installable by kpackagetool5.
in the future, the port should be completed and replace all the manual lookup
of files with package::filePath as it should work now given that valid
structures exist

BUG:374766

Test Plan

tabbox plugins and kwin scripts can be installed from knewstuff
again and can be successfully loaded

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 10357.Jan 19 2017, 5:21 PM
mart retitled this revision from to use proper packagestructures.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptJan 19 2017, 5:21 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript

I assume that should go into the 5.9 branch?

what about window decoration themes (aka aurorae)? Does that also need adjustment?

mart added a comment.Jan 19 2017, 8:18 PM

I assume that should go into the 5.9 branch?

quite a big backport.. but yeah, may make sense as 5.9 release would be kinda broken otherwise

what about window decoration themes (aka aurorae)? Does that also need adjustment?

aurorae seems to not use kpackage at all, tarballs are uncompressed directly, so they keep installing fine

graesslin accepted this revision.Jan 20 2017, 5:21 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jan 20 2017, 5:21 AM
This revision was automatically updated to reflect the committed changes.
romangg edited edge metadata.Jan 20 2017, 2:41 PM

Just for keeping record: The only issue I noticed is that the config button in scripts isn't displayed. Besides works very nice!