Differential D4175

Introduce a QCommandLineParser for kglobalaccel5
ClosedPublic
Actions

Authored by apol on Jan 17 2017, 5:41 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Commits
R268:8e6f7b79c863: Introduce a QCommandLineParser for kglobalaccel5
Summary

It's useful to be able to check the version and so.

Test Plan

Running kglobalaccel5 --help doesn't execute the service.

Diff Detail

Repository
R268 KGlobalAccel
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 10293.Jan 17 2017, 5:41 PM
apol retitled this revision from to Introduce a QCommandLineParser for kglobalaccel5.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 17 2017, 5:41 PM
davidedmundson accepted this revision.Jan 17 2017, 6:41 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 17 2017, 6:41 PM
graesslin added a subscriber: graesslin.Jan 17 2017, 9:12 PM
graesslin added inline comments.
src/runtime/main.cpp
63

Why did you scope the parser?

apol added inline comments.Jan 17 2017, 10:49 PM
src/runtime/main.cpp
63

So that it frees the QCLP resources as we're not going to be using them anymore. I agree it's not much, but also there's little reason to keep it alive for the whole run of the process.

Closed by commit R268:8e6f7b79c863: Introduce a QCommandLineParser for kglobalaccel5 (authored by apol). · Explain WhyJan 17 2017, 10:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/runtime/main.cpp (8 lines)

Diff 10304

View Options

src/runtime/main.cpp

Loading...