Differential D4076

Kill the revision graph view
ClosedPublic
Actions

Authored by flherne on Jan 10 2017, 11:01 PM.

Details

Reviewers

kfunk

Group Reviewers

KDevelop

Commits

R32:74740196a291: Remove the Revision Graph
R33:74740196a291: Remove the Revision Graph

Summary

It doesn't work, hasn't worked for years, and hangs the entire UI for up to a minute while trying to draw the result.

Breaks ABI, obviously.

Test Plan

Compiles, feature is gone.

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

flherne updated this revision to Diff 10012.Jan 10 2017, 11:01 PM

flherne retitled this revision from to Kill the revision graph view.

flherne updated this object.

flherne edited the test plan for this revision. (Show Details)

flherne set the repository for this revision to R33 KDevPlatform.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 10 2017, 11:01 PM

flherne added reviewers: kfunk, KDevelop.Jan 10 2017, 11:02 PM

+1 from my side, the feature is broken and I don't want to fix it. There's enough tools showing git history graphs on the world.

I saw you talked about backporting this.

IMO let's just push this to master (since it changes public API).

In 5.0/5.1 let's just remove the action from the menu. Easy enough.

This revision is now accepted and ready to land.Jan 11 2017, 12:56 AM

Done:

*   c1e54cc - (HEAD -> 5.1, origin/5.1) Merge remote-tracking branch 'origin/5.0' into 5.1 (26 seconds ago) <Kevin Funk>
|\  
| * b3896fe - (origin/5.0, 5.0) Disable the Revision Graph feature (75 seconds ago) <Kevin Funk>

Closed by commit R33:74740196a291: Remove the Revision Graph (authored by flherne). · Explain WhyJan 11 2017, 9:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		vcs/CMakeLists.txt (2 lines)
M		vcs/dvcs/dvcsplugin.h (1 line)
M		vcs/dvcs/dvcsplugin.cpp (27 lines)
D	M	vcs/dvcs/ui/revhistory/commitView.h (62 lines)
D	M	vcs/dvcs/ui/revhistory/commitView.cpp (238 lines)
D	M	vcs/dvcs/ui/revhistory/commitlogmodel.h (67 lines)
D	M	vcs/dvcs/ui/revhistory/commitlogmodel.cpp (100 lines)