Kill the revision graph view
ClosedPublic

Authored by flherne on Jan 10 2017, 11:01 PM.

Details

Summary

It doesn't work, hasn't worked for years, and hangs the entire UI for up to a minute while trying to draw the result.

Breaks ABI, obviously.

Test Plan

Compiles, feature is gone.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
flherne updated this revision to Diff 10012.Jan 10 2017, 11:01 PM
flherne retitled this revision from to Kill the revision graph view.
flherne updated this object.
flherne edited the test plan for this revision. (Show Details)
flherne set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 10 2017, 11:01 PM
brauch added a subscriber: brauch.Jan 10 2017, 11:07 PM

+1 from my side, the feature is broken and I don't want to fix it. There's enough tools showing git history graphs on the world.

kfunk accepted this revision.Jan 11 2017, 12:56 AM
kfunk edited edge metadata.

I saw you talked about backporting this.

IMO let's just push this to master (since it changes public API).

In 5.0/5.1 let's just remove the action from the menu. Easy enough.

This revision is now accepted and ready to land.Jan 11 2017, 12:56 AM
kfunk added a comment.Jan 11 2017, 1:00 AM

Done:

*   c1e54cc - (HEAD -> 5.1, origin/5.1) Merge remote-tracking branch 'origin/5.0' into 5.1 (26 seconds ago) <Kevin Funk>
|\  
| * b3896fe - (origin/5.0, 5.0) Disable the Revision Graph feature (75 seconds ago) <Kevin Funk>
This revision was automatically updated to reflect the committed changes.