Differential D4060

kio: Ensure user certificate directory has been created before storing certs to it
ClosedPublic
Actions

Authored by mpyne on Jan 10 2017, 3:26 AM.

Details

Reviewers
apol
ahartmetz
Group Reviewers
Frameworks
Summary

The KSSL KCM fails to save imported certificates to the user certificate store (without an error message either), as reported by multiple users in bug 342958.

The bug report lead to a workaround to manually creating the needed directory first, which makes the KCM work fine.

This patch fixes the reported bug by ensuring that the userDir directory has been created (using QDir::mkpath) before trying to save the certificates. Due to the KCM code layout (the KCM is in kdelibs4support) the relevant code is in KIO.

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
mpyne updated this revision to Diff 9955.Jan 10 2017, 3:26 AM
mpyne retitled this revision from to kio: Ensure user certificate directory has been created before storing certs to it.
mpyne updated this object.
mpyne edited the test plan for this revision. (Show Details)
mpyne added reviewers: Frameworks, ahartmetz.
mpyne set the repository for this revision to R241 KIO.
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 10 2017, 3:26 AM
apol accepted this revision.Jan 10 2017, 10:54 AM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Jan 10 2017, 10:54 AM
ahartmetz edited edge metadata.Jan 10 2017, 9:32 PM

Looks like a stupid mistake on my part, thanks for the fix.

mpyne closed this revision.Jan 12 2017, 12:00 AM

This diff was pushed to kio, closing manually since I seem to have messed up the commit msg. See https://cgit.kde.org/kio.git/commit/?id=d06e40bc1e84391640fc56a4c5ba252eaa9dcc6d

Revision Contents
Changeset List

Diff 9955

View Options

src/core/ksslcertificatemanager.cpp

Loading...