QML sizes can be fractional. In case we're asked to load a 31.5 px pixmap it would truncate it to 31 and then round down to 22 causing a blurry result. Instead, round the size.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R242:0a7ae2ce97c4: [Icon Item] Round size we want to load a pixmap in
Fixes blurry media controls in task manager for me.
Problem is also that the new aspect-ratio aware IconItem always scales the pixmap up to its size regardless of the pixmap size. In any case this patch still makes sense imho
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Just tested and this solves pixelated launcher icons, i.e. https://bugs.kde.org/show_bug.cgi?id=374707
Comment Actions
It seems there have been problems with this before the new aspect-ratio aware IconItem aswell. See https://bugs.kde.org/show_bug.cgi?id=365326
Could your patch also solve this issue? Then we need to backport it to 5.8.
Comment Actions
though typically we do rounding in the QML side as it can cause these problems with some other items too.