[Units] Make iconSizes property constant
ClosedPublic
Actions

Authored by broulik on Jan 8 2017, 11:49 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R242:4479fdab7fff: [Units] Make iconSizes property constant

Summary

It's not the property that changes (we don't assign a new QQmlPropertyMap) but the properties within and it's already smart enough to signal this.

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Units] Make iconSizes property constant.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R242 Plasma Framework (Library).

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

This revision is now accepted and ready to land.Jan 8 2017, 12:29 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/declarativeimports/core/units.h (3 lines)
M			src/declarativeimports/core/units.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9842			Jan 8 2017, 11:48 AM	★	★
Diff 2	9860	5677301	R242:4479fdab7fffede946e0df060a1e43b75ab1d3e6	Jan 8 2017, 3:02 PM	★	★