Differential D4013

[Units] Make iconSizes property constant
ClosedPublic
Actions

Authored by broulik on Jan 8 2017, 11:49 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:4479fdab7fff: [Units] Make iconSizes property constant
Summary

It's not the property that changes (we don't assign a new QQmlPropertyMap) but the properties within and it's already smart enough to signal this.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 9842.Jan 8 2017, 11:49 AM
broulik retitled this revision from to [Units] Make iconSizes property constant.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 8 2017, 11:49 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jan 8 2017, 12:29 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 8 2017, 12:29 PM
Closed by commit R242:4479fdab7fff: [Units] Make iconSizes property constant (authored by broulik). · Explain WhyJan 8 2017, 3:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9842

View Options

src/declarativeimports/core/units.h

Loading...
View Options

src/declarativeimports/core/units.cpp

Loading...