[Kicker] Don't nuke favorites on startup
AbandonedPublic
Actions

Authored by hein on Jan 1 2017, 5:15 PM.

Details

Reviewers

mart
broulik

Group Reviewers

Plasma

Summary

Likely race introduced by using QQmlParserStatus in 3e88ac6

BUG: 374156

Test Plan

Explained in the comment.
Default favorites in Kicker show up properly and my changes persist across plasmashell reboots

Diff Detail

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik updated this revision to Diff 9588.Jan 1 2017, 5:15 PM

broulik retitled this revision from to [Kicker] Don't nuke favorites on startup.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added reviewers: Plasma, hein.

broulik set the repository for this revision to R119 Plasma Desktop.

Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2017, 5:15 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.Jan 2 2017, 10:28 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Jan 2 2017, 10:28 AM

mart mentioned this in D3805: Per-activity favorites (Final, again?).Jan 2 2017, 10:29 AM

Please give me some time to review this. I was looking into this regression before vacation as well and it was non-trivial, so I want to make sure this handles all the scenarios correctly.

Actually I can already say I don't like this approach - this means refresh() won't work if no favorites are set on the model. This happens to work for Kicker & co because they have favorites in the default config in Plasma as shipped by kde.org, but this could technically be overridden by a distro or handled differently by a different UI frontend.

This revision now requires changes to proceed.Jan 2 2017, 11:23 AM

BTW: Kai, if you don't want to work on this today-ish I'll give it another try some time this week.

hein mentioned this in D3978: Typo fix..Jan 5 2017, 10:00 AM

hein mentioned this in D3979: Fix race condition causing empty favorites..Jan 5 2017, 10:04 AM

Superseded by D3979

hein mentioned this in R119:b7976f0c2628: Fix race condition causing empty favorites..Jan 5 2017, 10:07 AM