Differential D3978

Typo fix.
AbandonedPublic
Actions

Authored by hein on Jan 5 2017, 10:00 AM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Summary

Fix race condition causing empty favorites.

This puts the frontend in charge of calling refresh() after the
favorites have been initially set by setting auto population at
completion to false. Also preserves original behavior by keeping
auto population default-on.

Fixes a regression from 3e88ac6.
BUG:374156

This is an alternative to D3910.

Diff Detail

Repository

R119 Plasma Desktop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

hein updated this revision to Diff 9747.Jan 5 2017, 10:00 AM

hein retitled this revision from to Typo fix..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added reviewers: Plasma, broulik.

hein added a subscriber: plasma-devel.

Restricted Application added a project: Plasma. · View Herald TranscriptJan 5 2017, 10:00 AM

Made an --amend fuckup.

Revision Contents
Changeset List

			Path	Packages
M			applets/kicker/package/contents/ui/main.qml (3 lines)
M			applets/kicker/plugin/rootmodel.h (8 lines)
M			applets/kicker/plugin/rootmodel.cpp (18 lines)
M			applets/taskmanager/package/contents/ui/ContextMenu.qml (2 lines)

Commit	Tree	Parents	Author	Summary	Date
b4f2adf64a81	dfa3cfeb0689	1fb597c6f3ae	Eike Hein	Fix race condition causing empty favorites. (Show More…)	Jan 5 2017, 9:57 AM
1fb597c6f3ae	61fd0f7ff2e1	121f55ecec5f	Eike Hein	Typo fix.	Jan 5 2017, 5:49 AM