| romangg | |
| hein |
| Plasma |
In filename editor(when wrap mode is on) the content height and height of Plasma::TextArea are out of sync.
When text is added the height of TextArea increases as expected but when text is deleted the height doesn't decrease.
This patch attempts to fix the issue.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Good find but why does it need to compare _height with contentHeight in the beginning at all? Normally what should imo happen is simply:
So just: _height = Math.min(realHeight, maxHeight)
Just a nitpick: Since you have realHeight as the first argument, maybe also define it as first.
This was actually intentional in the original patch, the author preferred to expand but not shrink, and I didn't mind. I also don't mind shrinking though, I see Roman's point here (IRC):
[19:51] <romangg> Don't quite see how this could be unergonomic. tried it out myself and it works well when the text are is also shrinking. In fact it's somehow missleading if it doesn't because it looks like you've pressed space bar a lot or enter key.
Accepting.