Differential D385

Add special version of findExecutable for CMake plugin.
ClosedPublic
Actions

Authored by arrowd on Sep 30 2015, 6:26 AM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Maniphest Tasks
T598: Windows: Make sure CMake location is configurable
Summary

Besides looking in PATH, it also searches in CMake's standard installation dirs on Windows.

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
arrowd updated this revision to Diff 935.Sep 30 2015, 6:26 AM
arrowd retitled this revision from to Add special version of findExecutable for CMake plugin..
arrowd updated this object.
arrowd edited the test plan for this revision. (Show Details)
arrowd added a reviewer: KDevelop.
arrowd set the repository for this revision to R32 KDevelop.
arrowd added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 30 2015, 6:26 AM
apol added a subscriber: apol.Sep 30 2015, 1:20 PM

So QStandardPaths::findExecutable just doesn't work on Windows?

arrowd added a comment.Sep 30 2015, 1:50 PM

It works, it's just PATH not always set to CMake bin directory.

mwolff accepted this revision.Oct 8 2015, 9:24 AM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

please change the minor nitpick, otherwise +1

projectmanagers/cmake/cmakeutils.cpp
277

please wrap that in if Q_OS_WINDOWS or however the macro is there.

we don#t want to run this on Linux, if cmake is not installed.

This revision is now accepted and ready to land.Oct 8 2015, 9:24 AM

Revision Contents
Changeset List

Diff 935

View Options

projectmanagers/cmake/cmakebuilddirchooser.cpp

Loading...
View Options

projectmanagers/cmake/cmakemanager.cpp

Loading...
View Options

projectmanagers/cmake/cmakeutils.h

Loading...
View Options

projectmanagers/cmake/cmakeutils.cpp

Loading...
View Options

projectmanagers/cmake/settings/cmakepreferences.cpp

Loading...