Renamed all files/classes to CamelCase with KReport prefix
(except some internal and classes in plugins still to do)
Details
ran auto tests and example app
Diff Detail
- Repository
- R14 KReport
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/common/KReportPageOptions.h | ||
---|---|---|
41 | BTW, make all get* methods const. | |
61 | BTW, -> const | |
66 | -> QString getLabelType() const | |
src/items/check/KReportCheckBoxPlugin.h | ||
27 | -> KReportCheckBoxPlugin | |
src/items/check/KReportDesignerItemCheckBox.h | ||
30 | -> KReportDesignerItemCheckBox | |
src/items/check/KReportItemCheck.h | ||
32 | -> KReportItemCheckBox | |
src/items/check/KReportScriptCheck.h | ||
29 | -> CheckBox | |
src/items/field/KReportFieldPlugin.cpp | ||
2 | It seems to be marked as deleted instead of 'moved'. | |
src/items/image/KReportDesignerItemImage.h | ||
27 | -> KReportDesignerItemBarcode | |
src/items/image/KReportImagePlugin.cpp | ||
2 | It shows as a new file, not a rename... | |
src/plugins/barcode/KReportBarcodePlugin.h | ||
25 | -> KReportBarcodePlugin | |
src/plugins/barcode/KReportItemBarcode.h | ||
34 | -> KReportItemBarcode | |
src/plugins/chart/KReportChartPlugin.h | ||
25 | KReportChartPlugin | |
src/plugins/chart/KReportItemChart.h | ||
35 | -> KReportItemChart | |
src/plugins/maps/KReportItemMaps.h | ||
44 | -> KReportItemMaps | |
src/plugins/maps/KReportMapRenderer.cpp | ||
31 | -> KReportMapsRenderer | |
src/plugins/maps/KReportMapsPlugin.h | ||
26 | -> KReportMapsPlugin | |
src/plugins/web/KReportItemWeb.h | ||
42 | -> KReportItemWeb | |
src/plugins/web/KReportWebPlugin.cpp | ||
21 | -> KReportDesignerItemWeb | |
src/plugins/web/KReportWebPlugin.h | ||
25 | -> KReportWebPlugin | |
src/renderer/KReportAsyncItemManager_p.h | ||
32–33 | move to KReportASyncItemManager_p.cpp | |
33 | -> namespace KReportPrivate class AsyncItemManager | |
src/renderer/KReportHTMLCSSRenderer_p.h | ||
25–27 | -> namespace KReportPrivate class HTMLCSSRenderer | |
src/renderer/KReportHTMLTableRenderer_p.h | ||
25–27 | -> namespace KReportPrivate class HTMLTableRenderer | |
src/renderer/scripting/KReportScriptLine.h | ||
36 | For now that's correct change for all the scripting classes, just note the comment I added about scripting in T709. | |
src/wrtembed/KReportDesigner.cpp | ||
67 | Perhaps no need to have it in a separate class? Move contents to KReportDesigner::Private? | |
src/wrtembed/KReportDesignerScene.h | ||
38 | -> KReportDesignerScene | |
src/wrtembed/KReportDesignerSceneView.h | ||
26 | -> KReportDesignerScene | |
src/wrtembed/KReportDesignerSection.cpp | ||
348 | -> KReportDesignerSectionTitle | |
src/wrtembed/KReportDesignerSectionDetail.h | ||
36 | -> KReportDesignerSectionDetail | |
src/wrtembed/KReportDesignerSectionDetailGroup.cpp | ||
150 | BTW: yes -> visible | |
src/wrtembed/KReportDesignerSectionDetailGroup.h | ||
36 | -> KReportDesignerSectionDetailGroup |
src/common/KReportItemLine.h | ||
---|---|---|
57–58 | why? weight should always be >= 0 ? |
src/common/KReportItemLine.h | ||
---|---|---|
57–58 | Yes but following the Qt API design, if we use int everywhere code is simpler. The unsigned would be casted to int in real apps, e.g. when comparing with indices. We had many unsigned in KDb for example and now without it I see things are easier to use. |
src/common/KReportItemBase.cpp | ||
---|---|---|
46 | Removed this class and used new KReportLineStyle that you created using sdc |
src/renderer/KReportPage.h | ||
---|---|---|
33 | but its not an item in the sense of a report 'item' (object) |
- Address most of the comments from staniek
- Merge branch 'master' of git://anongit.kde.org/kreport
Much improved, thanks!
src/common/KReportAsyncItemBase.h | ||
---|---|---|
20–21 | Why KO and Ko ? | |
src/common/KReportDocument.h | ||
19–20 | why reverted? | |
src/common/KReportItemBase.cpp | ||
46 | Very good. | |
src/common/KReportPageOptions.h | ||
27 | ok | |
src/renderer/KReportHTMLCSSRenderer_p.cpp | ||
19–21 | why reverted? | |
src/renderer/KReportHTMLTableRenderer_p.cpp | ||
19–20 | why reverted? | |
src/renderer/KReportHTMLTableRenderer_p.h | ||
18–19 | why reverted? | |
src/renderer/KReportODTRenderer.h | ||
10 | OK | |
src/renderer/KReportPrintRenderer_p.cpp | ||
19–23 | why reverted? | |
20 | this include shall stay first | |
src/renderer/KReportPrintRenderer_p.h | ||
18–19 | why reverted? | |
src/renderer/KReportScreenRenderer_p.cpp | ||
19–22 | why reverted? | |
src/renderer/KReportScreenRenderer_p.h | ||
18–19 | why reverted? | |
src/wrtembed/KReportDesigner.cpp | ||
67 | ok | |
src/wrtembed/KReportDesignerScene.cpp | ||
19–25 | why reverted? | |
src/wrtembed/KReportDesignerScene.h | ||
25–26 | why reverted? | |
src/wrtembed/KReportDesignerSceneView.cpp | ||
22–23 | why reverted? | |
src/wrtembed/KReportDesignerSceneView.h | ||
19–20 | why reverted? | |
26 | Not done...? | |
src/wrtembed/KReportDesignerSectionDetail.h | ||
19 | KREPORTSECTIONDETAIL_H -> KREPORTDESIGNERSECTIONDETAIL_H | |
19–20 | why reverted? | |
src/wrtembed/KReportDesignerSectionDetailGroup.h | ||
19 | KREPORTSECTIONDETAILGROUP_H -> KREPORTDESIGNERSECTIONDETAILGROUP_H | |
19–20 | why reverted? | |
src/wrtembed/KReportSectionEditor.cpp | ||
1 | filename? | |
src/wrtembed/KReportSectionEditor.h | ||
1 | filename? |
jstaniek, i dont understand the comments about things being reverted, could you clarify, ta
src/wrtembed/KReportSectionEditor.h | ||
---|---|---|
1 | I just clicked a diff between Diff 1 and Diff 2 and this is example result: |
src/wrtembed/KReportDesignerSceneView.h | ||
---|---|---|
26 | Yes, KReportDesignerScene would be good |
src/wrtembed/KReportDesignerSceneView.h | ||
---|---|---|
26 | We already have KReportDesignerScene .... this is the View :) |
Please look at the D383-big-rename branch. I've renamed the remaining Ko* symbols for you and the KReportDesignerView. Except in ods/ and odtframe/.
If OK we could commit it on Monday.
src/wrtembed/KReportDesignerSceneView.h | ||
---|---|---|
26 | I am sorry. I mean KReportDesignerView would be best IMHO. Also this is a Designer's class. |