Differential D3833

export kwin theme to l&f
ClosedPublic
Actions

Authored by mart on Dec 28 2016, 1:34 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R118:229803bec3e5: export kwin theme to l&f
R855:229803bec3e5: export kwin theme to l&f
Summary

export also kwin theme to look and feel themes
including the button order
tabbox and desktoip switcher are fixed to be taken from the
proper groups

Test Plan

created a customized lnf theme that is properly applied

Diff Detail

Repository
R118 Plasma SDK
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 9414.Dec 28 2016, 1:34 PM
mart retitled this revision from to export kwin theme to l&f.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 28 2016, 1:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Dec 28 2016, 4:04 PM
graesslin added inline comments.
lookandfeelexplorer/src/lnflogic.cpp
161

this is not the default used by kwin. KWin determines the default based on the optional compile time dep on breeze

164

like in the other request I don't like this being exported.

mart added inline comments.Dec 28 2016, 4:06 PM
lookandfeelexplorer/src/lnflogic.cpp
164

would empty string make it use the default?

graesslin added inline comments.Dec 28 2016, 5:47 PM
lookandfeelexplorer/src/lnflogic.cpp
164

no, empty string would result in no buttons at all.

mart updated this revision to Diff 9439.Dec 29 2016, 11:25 AM
  • drop buttons order
mart updated this revision to Diff 9449.Dec 29 2016, 12:49 PM
  • export servicetypes
Closed by commit R118:229803bec3e5: export kwin theme to l&f (authored by mart). · Explain WhyJan 4 2017, 1:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9701

View Options

lookandfeelexplorer/src/lnflogic.cpp

Loading...