support both button order and decoration theme
of kwin when applying for a lnf theme. The deco
theme is composed by library and theme entries.
c++ themes will only use library, aurorae themes will use
theme as well.
BUG:370511
graesslin |
Plasma |
support both button order and decoration theme
of kwin when applying for a lnf theme. The deco
theme is composed by library and theme entries.
c++ themes will only use library, aurorae themes will use
theme as well.
BUG:370511
created some lnf packages that customize this and applied
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
the user request was to make possible the l&f themes to emulate a different os (that is actually part of the design reason of l&f themes) in which button order becomes part of the target look
To be more precise it was my request. The reason: for plasma 5.9 I would like to upload to kde store a few look and feel packages, which are mimicking certain desktop environments/operating systems like seen in this video https://www.youtube.com/watch?v=G4InY_1UhTI It would fit nicely with our upcoming Plasma 5.9 promo video etc.
the button order is global and not per theme. Given that I think it is wrong to change the global button order when changing theme. IIRC the deco can override it anyway, so not needed here.
the button order is global and not per theme. Given that I think it is wrong to change the global button order when changing theme. IIRC the deco can override it anyway, so not needed here.
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
664–668 | now we have two sections which will reload KWin's config. Can we merge that? A reload of KWin's config can be really expensive and we don't want to do that twice. |
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
664–668 | maybe an even compression with a timer? |
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
664–668 | in KWin? eh, no, please not. |
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
664–668 | nono, i meant in the kcm :) |
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
664–668 | ok :-) yeah that could be neat as it also allows to unstress the system a bit. |
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
338 | what remains is that this is not the default used in KWin. In KWin it's: static const QString s_aurorae = QStringLiteral("org.kde.kwin.aurorae"); static const QString s_pluginName = QStringLiteral("org.kde.kdecoration2"); #if HAVE_BREEZE_DECO static const QString s_defaultPlugin = QStringLiteral(BREEZE_KDECORATION_PLUGIN_ID); #else static const QString s_defaultPlugin = s_aurorae; #endif |
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
342 | I think you got that part wrong. The difference is the value passed to library. |
kcms/lookandfeel/kcm.cpp | ||
---|---|---|
342 | eew, sorry, that's what you get for writing that before cofee :/ |