Correctly remove stale next bucket links when items are removed
AbandonedPublic

Authored by kossebau on Sep 27 2015, 11:08 AM.

Details

Reviewers
mwolff
olivierjg
Group Reviewers
KDevelop
Summary
This fixes an assertion that can occur in an edge case when there
is a clashing monster bucket followed by another clashing item.

This should improve index/findIndex performance as they no longer
need to search these stale links. It's hard to predict if this
is significant, but at least it should prevent performance
degradation in item repositories over time.
Test Plan

Extended unit test

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
olivierjg updated this revision to Diff 929.Sep 27 2015, 11:08 AM
olivierjg retitled this revision from to Correctly remove stale next bucket links when items are removed.
olivierjg updated this object.
olivierjg edited the test plan for this revision. (Show Details)
olivierjg added reviewers: KDevelop, mwolff.
olivierjg set the repository for this revision to R33 KDevPlatform.
olivierjg added a project: KDevelop.
olivierjg added a subscriber: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. ยท View Herald TranscriptSep 27 2015, 11:08 AM
mwolff edited edge metadata.Sep 27 2015, 6:39 PM

lgtm in principle

serialization/itemrepository.h
476

put brace on newline, make const?

mwolff accepted this revision.Oct 8 2015, 10:10 AM
mwolff edited edge metadata.

accepting

This revision is now accepted and ready to land.Oct 8 2015, 10:10 AM

This needs additional testing, as the added assertion is hit in real-world code.

@olivierjg, I assume from your last comment that you mean to make more changes.
When this is the case, you can select "Changes Planned" (Not sure on the exact language, only visible to owner), as the Action and make a comment. It's useful because then this diff drops out of everyone else's 'action required' list.

olivierjg planned changes to this revision.Dec 16 2015, 6:14 AM

Changes planned.

kfunk added a subscriber: kfunk.Aug 29 2016, 7:58 PM

@olivierjg: Got some news for us?

Bump. Got time to work on this?

kossebau commandeered this revision.Oct 28 2018, 12:53 PM
kossebau abandoned this revision.
kossebau added a reviewer: olivierjg.

Abandoning for now given inactivity by the original author, for cleaning the to-review list. Still hoping one day someone/you will pick up this again.