Differential D3759

Don't double emit titleChanged
ClosedPublic
Actions

Authored by davidedmundson on Dec 20 2016, 12:08 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R242:63a889ea0d16: Don't double emit titleChanged
Summary

AppletInterface::setTitle calls Applet::setTitle -- which in turn emits
Applet::titleChanged

Applet::titleChanged is already connected to
AppletInterface::titleChanged

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 9213.Dec 20 2016, 12:08 PM
davidedmundson retitled this revision from to Don't double emit titleChanged.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 20 2016, 12:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Dec 20 2016, 1:23 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Dec 20 2016, 1:23 PM
Closed by commit R242:63a889ea0d16: Don't double emit titleChanged (authored by davidedmundson). · Explain WhyDec 20 2016, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9217

View Options

src/scriptengines/qml/plasmoid/appletinterface.cpp

Loading...