[Folder View] Workaround QML Text layouting glitch
ClosedPublic

Authored by broulik on Dec 19 2016, 8:22 PM.

Details

Summary

We change the height in response to becoming visible which confuses the eliding in the Label and then it doesn't render.

Test Plan

I now consistently get a proper title in my folder view popup rather than an empty spot.

Binding to visible often leads to unexpected results as visible will recursively switch to false when the root item hides, etc

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9184.Dec 19 2016, 8:22 PM
broulik retitled this revision from to [Folder View] Workaround QML Text layouting glitch.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 19 2016, 8:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Dec 20 2016, 12:28 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Dec 20 2016, 12:28 AM
This revision was automatically updated to reflect the committed changes.