Differential D3743

[Folder View] Show proper trash icon when it points to trash:/
AbandonedPublic
Actions

Authored by broulik on Dec 19 2016, 8:08 PM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma: Design
Plasma
Summary

This will have FolderView show the correct trash icon (full or empty) when it points to the "Trash" location.
Currently it would just show a generic folder icon.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 9182.Dec 19 2016, 8:08 PM
broulik retitled this revision from to [Folder View] Show proper trash icon when it points to trash:/.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 19 2016, 8:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 21 2016, 11:46 AM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
containments/desktop/plugins/folder/foldermodel.cpp
235

I wonder if KFileItem itself should return proper trash icons?

This revision is now accepted and ready to land.Dec 21 2016, 11:46 AM
hein edited edge metadata.Jan 2 2017, 6:28 AM

I agree with mart's review comment ... why did we need to hardcode this in FV code, Kai?

broulik abandoned this revision.Mar 27 2017, 5:13 PM

Superseded by D5198 and D5199

Revision Contents
Changeset List

Diff 9182

View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...