Reflect trash state in iconNameForUrl
ClosedPublic
Actions

Authored by broulik on Mar 27 2017, 4:54 PM.

Details

Reviewers

hein
dfaure

Commits

R241:ca6e6c0469a5: Reflect trash state in iconNameForUrl

Summary

When doing iconNameForUrl("trash:/") reflect the state of the trash (full or empty)

Test Plan

Did KIO::iconNameForUrl("trash:/") with empty trash, it was "user-trash", then I trashed a file and it returned "user-trash-full", see also D5198

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

This revision is now accepted and ready to land.Mar 27 2017, 4:55 PM

Err.. sorry.. accepted wrong revision. Looks good but ignore me

bshah resigned from this revision.Mar 27 2017, 4:57 PM

This revision now requires review to proceed.Mar 27 2017, 4:57 PM

Hmm, i don't know about the performance penalty you get when using KConfig...
It "looks" ok, but that's without knowing the above.

+1, ship it is for someone else.

Yep it means parsing a file, but that file is exactly 2 lines long and this is only done when asking about trash:/ so I think it's fine.

This revision is now accepted and ready to land.Mar 27 2017, 5:10 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/global.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12872			Mar 27 2017, 4:53 PM	★	★
Diff 2	24212	ffffa43	R241:ca6e6c0469a58501f8c5fa850525791ada208e11	Dec 21 2017, 11:45 AM	★	★