Details
Details
- Reviewers
apol cordlandwehr - Group Reviewers
Frameworks - Commits
- R240:957e00fe3d32: Document usage of gnustl_shared with Android toolchain
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
http://doc.qt.io/qbs/android-ndk-module.html allows to control which helper runtime to use, so hardcoding gnustl_shared in the ECM toolchain could have been done for a certain reason or perhaps just was done once to get started, but never revisited?
| toolchain/Android.cmake | ||
|---|---|---|
| 160 | when I started working on Android it was the only one available and it's the one we test things on on GNU/Linux, so I'd say it's safer to stay on gnustl unless there's a very good reason to move away from it. | |
| 164 | There's not really a chance, if it's not there it's an error. I'd remove this comment altogether. | |