Differential D359

Flag KTextWidgets and KTextEditor as optional
AbandonedPublic
Actions

Authored by abrahams on Sep 17 2015, 5:23 PM.

Details

Reviewers
staniek
rempt
kossebau

Diff Detail

Repository
R8 Calligra
Branch
optional-text-libs
Lint
No Linters Available
Unit
No Unit Test Coverage
abrahams updated this revision to Diff 890.Sep 17 2015, 5:23 PM
abrahams retitled this revision from to Flag KTextWidgets and KTextEditor as optional.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added reviewers: kossebau, staniek, rempt.
staniek requested changes to this revision.Sep 17 2015, 5:28 PM
staniek edited edge metadata.

I'd like to ask to wait for my patch as I noted via email.
TextEditor is just optional, find_package belongs to Kexi.

This revision now requires changes to proceed.Sep 17 2015, 5:28 PM
staniek added a comment.Sep 17 2015, 6:13 PM

Precisely, please see D362

abrahams abandoned this revision.Sep 17 2015, 6:54 PM

Haha, I sent the diff just a few minutes before I saw you fixed the whole dependency section. This is obsolete with D362

staniek added a comment.Sep 17 2015, 7:00 PM

Yeah. Extra funny that same here regarding the KoXmlReader bug.
The same fix as yours, my explanation is:

KoXmlReader: for Qt5+msvc can't use QXmlStreamAttributes::const_iterator
See https://bugreports.qt.io/browse/QTBUG-45368

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (10 lines)

Diff 890

View Options

CMakeLists.txt

Loading...