Differential D3501

Scale surface damage events
ClosedPublic
Actions

Authored by davidedmundson on Nov 25 2016, 10:22 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:e2e2c86f3740: Scale surface damage events
Summary

Damage events come in global compositor space, not relative to the surface.
For a glTex2D we need the events relatvie to the surface, so they need scaling up

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 8509.Nov 25 2016, 10:22 AM
davidedmundson retitled this revision from to Scale surface damage events Damage events come in global compositor space, not relative to the surface. For a glTex2D we need the events relatvie to the surface, so they need scaling up.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptNov 25 2016, 10:22 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Nov 25 2016, 2:30 PM
graesslin added inline comments.
abstract_egl_backend.cpp
363

nitpick

372–384

I'm wondering whether the partial upload makes sense at all now. Maybe we should just upload the complete texture?

Note: I have vague ideas of using a texture upload thread.

402

nitpick

davidedmundson updated this revision to Diff 8607.Nov 29 2016, 4:30 PM
davidedmundson retitled this revision from Scale surface damage events Damage events come in global compositor space, not relative to the surface. For a glTex2D we need the events relatvie to the surface, so they need scaling up to Scale surface damage events.
davidedmundson updated this object.

Cleanup whitespace

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptNov 29 2016, 4:30 PM
graesslin accepted this revision.Dec 9 2016, 6:18 PM
graesslin added a reviewer: graesslin.

You added a typo in the commit message: "relatvie" -> relative

This revision is now accepted and ready to land.Dec 9 2016, 6:18 PM
Closed by commit R108:e2e2c86f3740: Scale surface damage events (authored by davidedmundson). · Explain WhyApr 29 2017, 1:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mabstract_egl_backend.cpp (16 lines)

Diff 13972

View Options

abstract_egl_backend.cpp

Loading...