Differential D3481

[applets] Support KWin/Wayland in ColorPicker
ClosedPublic
Actions

Authored by graesslin on Nov 24 2016, 7:12 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R114:1bca39d22941: [applets] Support KWin/Wayland in ColorPicker
Summary

KWin provides a DBus interface for interactive color picking. This
allows to have a color picker on Wayland.

To use this the GrabWidget is refactored and an abstract Grabber class
is split out. The current functionality using an (X11) window is moved
into an X11Grabber class and a new class KWinWaylandGrabber is added
which performs the interaction through DBus.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8466.Nov 24 2016, 7:12 AM
graesslin retitled this revision from to [applets] Support KWin/Wayland in ColorPicker.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 24 2016, 7:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Nov 24 2016, 10:00 AM
broulik edited edge metadata.

Awesome!

This revision is now accepted and ready to land.Nov 24 2016, 10:00 AM
Closed by commit R114:1bca39d22941: [applets] Support KWin/Wayland in ColorPicker (authored by graesslin). · Explain WhyNov 25 2016, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8498

View Options

applets/colorpicker/CMakeLists.txt

Loading...
View Options

applets/colorpicker/plugin/grabwidget.h

Loading...
View Options

applets/colorpicker/plugin/grabwidget.cpp

Loading...