If we get a notification with no body, treat the subject line as the body
ClosedPublic
Actions

Authored by davidedmundson on Nov 19 2016, 10:13 PM.

Details

Reviewers

Group Reviewers

Commits

R120:cbf06cf862c5: If we get a notification with no body, treat the subject line as the body
R871:cbf06cf862c5: If we get a notification with no body, treat the subject line as the body

Summary

BUG: 372112

Test Plan

notify-send "This long title that goes on and on" - wrapped with no title

notify-send "subject1" "msg1"
notify-send "subject1" "msg2" - appeared as one message with two lines

notify-send "subject2" "msg1"
notify-send "subject3" "msg2" - appeared as two notifications

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson updated this revision to Diff 8328.Nov 19 2016, 10:13 PM

davidedmundson retitled this revision from to If we get a notification with no body, treat the subject line as the body.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

davidedmundson added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptNov 19 2016, 10:13 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Is there a chance for a unit test there?

Heh, you were quicker :)

Can we perhaps use the application name as summary in case none is set?

broulik mentioned this in D3436: if only title set use as body.Nov 21 2016, 5:29 PM

ping? (if the appname is used as fallback for the title, this is good to go)

Updated as per request with app name

mart accepted this revision.Nov 29 2016, 11:43 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Nov 29 2016, 11:43 AM

Closed by commit R120:cbf06cf862c5: If we get a notification with no body, treat the subject line as the body (authored by davidedmundson). · Explain WhyDec 9 2016, 3:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			dataengines/notifications/notificationsengine.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8328	89f6a26		Nov 19 2016, 10:13 PM	★	★
Diff 2	8514	a79f279	Updated as per request with app name	Nov 25 2016, 11:16 AM	★	★
Diff 3	8892	14b45c3	R120:cbf06cf862c5779f2c16a6903e828c67d5c1a670	Dec 9 2016, 3:05 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
937ee6b53ce0	66023a81ec7e	a79f279f077e	David Edmundson	If we get a notification with no body, treat the subject line as the body (Show More…)	Nov 25 2016, 11:08 AM

Diff 8892

View Options

dataengines/notifications/notificationsengine.cpp