Differential D3417

KMessageWidget: move colors update to a private method
AbandonedPublic
Actions

Authored by elvisangelaccio on Nov 18 2016, 2:14 PM.

Details

Reviewers
cfeck
Summary

This way we can update the colors whenever we need to (e.g. see D3418). While at it, extends the manual test to make sure that no message type breaks.

Test Plan

All message widgets type still shows the right color.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
elvisangelaccio updated this revision to Diff 8307.Nov 18 2016, 2:14 PM
elvisangelaccio retitled this revision from to KWidgetsAddons: move colors update to a private method.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a dependent revision: D3418: KMessageWidget: use darker red color when close button is visible.Nov 18 2016, 2:23 PM
elvisangelaccio retitled this revision from KWidgetsAddons: move colors update to a private method to KMessageWidget: move colors update to a private method.
elvisangelaccio updated this object.
elvisangelaccio added a reviewer: cfeck.Nov 18 2016, 2:29 PM
elvisangelaccio added a project: Frameworks.
elvisangelaccio changed the visibility from "elvisangelaccio (Elvis Angelaccio)" to "Public (No Login Required)".
elvisangelaccio changed the edit policy from "elvisangelaccio (Elvis Angelaccio)" to "All Users".
elvisangelaccio abandoned this revision.Nov 21 2016, 10:24 AM

Change no longer necessary, I committed only the update to the test with a separate commit: http://commits.kde.org/kwidgetsaddons/149951aec4ce1a350cbe5fb00d13aae2ce06eece

Revision Contents
Changeset List

PathPackages
Msrc/kmessagewidget.cpp (134 lines)
Mtests/kmessagewidgettest.cpp (16 lines)

Diff 8307

View Options

src/kmessagewidget.cpp

Loading...
View Options

tests/kmessagewidgettest.cpp

Loading...