Differential D3415

[Task Manager] Pass local file to KService instead of stringified URL
ClosedPublic
Actions

Authored by broulik on Nov 18 2016, 11:39 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:a01792207c9c: [Task Manager] Pass local file to KService instead of stringified URL
Summary

KService doesn't know what to do with "file://"

Test Plan

Obviously we could do better ;)

Together with an upcoming patch I get unity badges by Mattermost (Electron) chat application

Verified that Chrome and Dolphin still show badges and download progress

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 8303.Nov 18 2016, 11:39 AM
broulik retitled this revision from to [Task Manager] Pass local file to KService instead of stringified URL.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2016, 11:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.Nov 18 2016, 12:29 PM

Can we / do we want to depend on the result of launcherUrl.toLocalFile() being a valid local path? Then we should use serviceByDesktopPath instead of serviceByStorageId. serviceByStorageId can work with a path, but the less fuzzy logic the better ...

broulik updated this revision to Diff 8306.Nov 18 2016, 1:36 PM
broulik edited edge metadata.

Use serviceByDesktopPath

hein accepted this revision.Nov 20 2016, 2:56 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Nov 20 2016, 2:56 PM
Closed by commit R119:a01792207c9c: [Task Manager] Pass local file to KService instead of stringified URL (authored by broulik). · Explain WhyNov 22 2016, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8381

View Options

applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp

Loading...