Differential D3416

[Task Manager] Strip application:// prefix before looking up service
ClosedPublic
Actions

Authored by broulik on Nov 18 2016, 11:42 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:5e1d92afd0b1: [Task Manager] Strip application:// prefix before looking up service
Summary

According to Unity Launcher API documentation [1] this prefix should be there, actually, so we weren't standard-compliant here.

[1] https://wiki.ubuntu.com/Unity/LauncherAPI

CHANGELOG: Badges and progress display in task manager now works with more 3rd party applications

Test Plan

Together with D3415 I now get badges by Mattermost (Electron) chat application

Verified that Chrome and Dolphin still show badges and download progress

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 8304.Nov 18 2016, 11:42 AM
broulik retitled this revision from to [Task Manager] Strip application:// prefix before looking up service.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2016, 11:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein added inline comments.Nov 18 2016, 12:30 PM
applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
152

Just QStringLiteral maybe?

broulik updated this revision to Diff 8305.Nov 18 2016, 1:36 PM

QStringLiteral

hein accepted this revision.Nov 20 2016, 2:56 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Nov 20 2016, 2:56 PM
Closed by commit R119:5e1d92afd0b1: [Task Manager] Strip application:// prefix before looking up service (authored by broulik). · Explain WhyNov 22 2016, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8382

View Options

applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp

Loading...